Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[WEBSITE] Correct Google Analytics Tracker#16490

Merged
aaronmarkham merged 1 commit intomasterfrom
szha-patch-1
Oct 19, 2019
Merged

[WEBSITE] Correct Google Analytics Tracker#16490
aaronmarkham merged 1 commit intomasterfrom
szha-patch-1

Conversation

@szha
Copy link
Member

@szha szha commented Oct 15, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@szha szha requested a review from aaronmarkham as a code owner October 15, 2019 17:22
@szha szha requested a review from mli October 15, 2019 17:22
@aaronmarkham
Copy link
Contributor

aaronmarkham commented Oct 15, 2019

Hi @szha - So the config for the ID should be here:
https://github.com/apache/incubator-mxnet/blob/master/docs/static_site/src/_config_prod.yml
It is there, so any mention of the tracker ID should be using the variable, not be statically defined.

@aaronmarkham
Copy link
Contributor

aaronmarkham commented Oct 15, 2019

It is setup to use it here: https://github.com/apache/incubator-mxnet/blame/master/docs/static_site/src/_includes/google-analytics.html

I'm not sure why there are two analytics files. Maybe this one should be deleted. I think the config is setup correctly because if you view source the ID is -1.

aaronmarkham
aaronmarkham previously requested changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind... I guess each micro site needs its own setup. Though, I'd much rather this was maintained centrally in one config.

@aaronmarkham aaronmarkham dismissed their stale review October 15, 2019 18:14

My mistake... looking at the jekyll config, not the python one. Though we should definitely have comments in there that mention where these files reside.

@ThomasDelteil
Copy link
Contributor

ThomasDelteil commented Oct 15, 2019

@aaronmarkham the python docs header is done through the theme which is loading the analytics file that @szha changed

@marcoabreu
Copy link
Contributor

marcoabreu commented Oct 17, 2019

Yeah agree, would be good to have these settings centralized

@szha szha changed the title Correct Google Analytics Tracker [WEBSITE] Correct Google Analytics Tracker Oct 17, 2019
@aaronmarkham aaronmarkham merged commit fc81c64 into master Oct 19, 2019
@szha szha deleted the szha-patch-1 branch October 20, 2019 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mli mli Awaiting requested review from mli

3 more reviewers

@ThomasDelteil ThomasDelteil ThomasDelteil approved these changes

@marcoabreu marcoabreu marcoabreu approved these changes

@aaronmarkham aaronmarkham aaronmarkham left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@szha @aaronmarkham @ThomasDelteil @marcoabreu