This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Merged
Conversation
haojin2
reviewed
Oct 18, 2019
2da0a29 to
00e43aa
Compare
haojin2
reviewed
Oct 20, 2019
haojin2
approved these changes
Oct 20, 2019
00e43aa to
8c11ef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed several things.
NDArray__setitem__now works in the following case. @astonzhangnp.true_dividesupports integral dtypes and outputs float32. @haojin2Loading legacy symbol json files in
np_shapesemantics. @stu1130 @frankfliuChecklist
Essentials
Please feel free to remove inapplicable items for your PR.