This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] ONNX Fixes for some NLP models#19973
Merged
Zha0q1 merged 4 commits intoapache:v1.xfrom Mar 3, 2021
Merged
Conversation
Contributor
Zha0q1
commented
Mar 3, 2021
- fix the output missing issue when the output is in the iniatilizer
- fix shape issue in zeros_ and ones_
- fix one_hot dtype issue
- fix scalar_op_helper multi-dimensional tensor not being flattened issue
- fix leaky_relu
|
Hey @Zha0q1 , Thanks for submitting the PR
CI supported jobs: [sanity, windows-cpu, unix-cpu, centos-gpu, centos-cpu, windows-gpu, clang, website, unix-gpu, edge, miscellaneous] Note: |
waytrue17
reviewed
Mar 3, 2021
| outputs=[name], | ||
| name=name) | ||
| elif act_type in ('gelu'): | ||
| elif act_type in ('gelu',): |
Contributor
Author
There was a problem hiding this comment.
otherwise this is not a tuple, and elu is in gelu so we will never go into the else branch
Contributor
There was a problem hiding this comment.
Should we use a list for this instead? Why a tuple?
elif act_type in ['gelu']:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.