Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Fix identity fuse for oneDNN#20767

Merged
bgawrych merged 4 commits intoapache:masterfrom
bgawrych:fix_identity
Jan 6, 2022
Merged

Fix identity fuse for oneDNN#20767
bgawrych merged 4 commits intoapache:masterfrom
bgawrych:fix_identity

Conversation

@bgawrych
Copy link
Contributor

@bgawrych bgawrych commented Dec 2, 2021

Description

During testing dmlc/gluon-nlp#1581 it occurred that identity fuse doesn't work properly on big graph, but works in unit test - that was caused by lack of stop condition in subgraph selector.

This PR fix this issue and expand test to cover such cases

@mxnet-bot
Copy link

mxnet-bot commented Dec 2, 2021

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, windows-gpu, website, unix-gpu, miscellaneous, sanity, edge, centos-gpu, windows-cpu, clang, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Dec 2, 2021
@bgawrych bgawrych changed the title Fix identity fuse Fix identity fuse for oneDNN Dec 2, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Dec 3, 2021

@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Dec 3, 2021

Jenkins CI successfully triggered : [unix-cpu, centos-gpu, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 3, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Dec 3, 2021

@mxnet-bot run ci [centos-gpu, unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Dec 3, 2021

Jenkins CI successfully triggered : [centos-gpu, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 3, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Dec 6, 2021

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Dec 6, 2021

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 6, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Dec 6, 2021

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Dec 6, 2021

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Dec 6, 2021
PawelGlomski-Intel
PawelGlomski-Intel approved these changes Dec 10, 2021
View reviewed changes
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Dec 16, 2021

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

mxnet-bot commented Dec 16, 2021

Jenkins CI successfully triggered : [unix-gpu, centos-cpu, unix-cpu, clang, centos-gpu, sanity, windows-gpu, edge, windows-cpu, miscellaneous, website]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 16, 2021
bartekkuncer
bartekkuncer approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@bartekkuncer bartekkuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 23, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 4, 2022
@bgawrych bgawrych merged commit 9fa75b4 into apache:master Jan 6, 2022
This was referenced Feb 3, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@bartekkuncer bartekkuncer bartekkuncer approved these changes

@agrabows agrabows agrabows approved these changes

@PawelGlomski-Intel PawelGlomski-Intel PawelGlomski-Intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bgawrych @mxnet-bot @bartekkuncer @agrabows @PawelGlomski-Intel @mseth10