Update shouldCheckForUpdate#2134
Merged
Merged
Conversation
mislav
suggested changes
Oct 8, 2020
mislav
left a comment
Contributor
There was a problem hiding this comment.
Thank you!
Could you also add documentation for GH_NO_UPDATE_NOTIFIER in help_topic.go among other environment variables?
| func shouldCheckForUpdate() bool { | ||
| return updaterEnabled != "" && !isCompletionCommand() && utils.IsTerminal(os.Stderr) | ||
| isCIEnvironment := (os.Getenv("CI") != "") || (os.Getenv("BUILD_NUMBER") != "") || (os.Getenv("RUN_ID") != "") | ||
| isGlobalDisabled := os.Getenv("GH_NO_UPDATE_NOTIFIER") == "disabled" |
Contributor
There was a problem hiding this comment.
Could this just check for GH_NO_UPDATE_NOTIFIER being set to any non-blank string, like the above checks?
The presence of "NO" in this variable implies that if the variable is set (to any value), update notifier will be disabled.
2. Updated test to check if passed variable is not empty
Contributor
Author
|
Apologies for closing. Clicked on the button by mistake 😅 |
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #743