Skip to content

Enable CoreCLR iOS and MacCatalyst device tests#33015

Merged
kotlarmilos merged 5 commits intodotnet:net11.0from
kotlarmilos:feature/coreclr-ios-device-tests
Dec 5, 2025
Merged

Enable CoreCLR iOS and MacCatalyst device tests#33015
kotlarmilos merged 5 commits intodotnet:net11.0from
kotlarmilos:feature/coreclr-ios-device-tests

Conversation

@kotlarmilos
Copy link
Member

Description

This PR enables CoreCLR iOS and MacCatalyst device tests, mirroring the existing Android CoreCLR device tests implementation.

Changes:

  • Added useCoreClr and /p:UseMonoRuntime=false when building with CoreCLR
  • Enabled device tests

Copilot AI review requested due to automatic review settings December 5, 2025 10:22
@kotlarmilos kotlarmilos self-assigned this Dec 5, 2025
@kotlarmilos kotlarmilos requested a review from rmarinho December 5, 2025 10:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables CoreCLR device tests for iOS and MacCatalyst platforms, complementing the existing Android CoreCLR device test infrastructure. The implementation correctly mirrors the Android pattern by adding useCoreClr parameter support and the /p:UseMonoRuntime=false MSBuild flag when CoreCLR is enabled.

Key Changes

  • Added CoreCLR test configurations for iOS and MacCatalyst in the pipeline YAML files
  • Extended iOS and Catalyst Cake build scripts to support the useCoreClr parameter
  • Updated binlog naming to differentiate between Mono and CoreCLR builds

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
eng/pipelines/common/device-tests.yml Added duplicate iOS and Catalyst platform test blocks with useCoreClr: true parameter, mirroring the existing Android CoreCLR pattern
eng/pipelines/common/device-tests-steps.yml Updated comment to include iOS and Catalyst platforms alongside Android
eng/pipelines/common/device-tests-jobs.yml Updated comment to include iOS and Catalyst platforms alongside Android
eng/devices/ios.cake Added useCoreClr parameter, modified ExecuteBuild to accept the parameter, added runtime-specific binlog naming, and conditionally appends /p:UseMonoRuntime=false
eng/devices/catalyst.cake Added useCoreClr parameter, modified ExecuteBuild to accept the parameter, added runtime-specific binlog naming, and conditionally appends /p:UseMonoRuntime=false

rolfbjarne
rolfbjarne previously approved these changes Dec 5, 2025
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@kotlarmilos kotlarmilos merged commit 21817df into dotnet:net11.0 Dec 5, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants