Enable CS1591 enforcement on projects with 100% doc coverage#33675
Merged
Enable CS1591 enforcement on projects with 100% doc coverage#33675
Conversation
- Controls.Core: Add WarningsAsErrors CS1591 - Compatibility: Remove CS1591 from NoWarn, add to WarningsAsErrors - BlazorWebView.Maui: Add WarningsAsErrors CS1591 - BlazorWebView.WindowsForms: Add WarningsAsErrors CS1591 - BlazorWebView.Wpf: Add WarningsAsErrors CS1591 All projects verified to build with 0 CS1591 errors.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables CS1591 (missing XML documentation warnings) as errors on 5 projects that already have 100% API documentation coverage, preventing future documentation regressions.
Changes:
- Added CS1591 to WarningsAsErrors for 4 projects (Controls.Core, Wpf, WindowsForms, Maui BlazorWebView)
- Moved CS1591 from NoWarn to WarningsAsErrors for Compatibility project
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Controls.Core.csproj | Added WarningsAsErrors property with CS1591 enforcement |
| Compatibility.csproj | Removed CS1591 from NoWarn and added to WarningsAsErrors |
| Microsoft.AspNetCore.Components.WebView.Wpf.csproj | Added WarningsAsErrors property with CS1591 enforcement |
| Microsoft.AspNetCore.Components.WebView.WindowsForms.csproj | Added WarningsAsErrors property with CS1591 enforcement |
| Microsoft.AspNetCore.Components.WebView.Maui.csproj | Added WarningsAsErrors property with CS1591 enforcement |
kubaflo
approved these changes
Jan 22, 2026
rmarinho
approved these changes
Jan 22, 2026
rmarinho
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
Enables CS1591 (missing XML documentation) as a warning-as-error on all projects that already have 100% API documentation coverage. This prevents future documentation gaps from being introduced.
Projects Updated
WarningsAsErrors: CS1591WarningsAsErrors: CS1591WarningsAsErrors: CS1591WarningsAsErrors: CS1591Verification
All 5 projects were built and verified to have 0 CS1591 errors before enabling enforcement.
Stats