Allow override of Vitess HTTP timeout#120
Merged
Merged
Conversation
gtowey
approved these changes
Apr 27, 2020
nickcanz
approved these changes
Apr 27, 2020
nickcanz
left a comment
There was a problem hiding this comment.
Yep, this looks good!
Question: if you thought about adding the timeout to the clusterSettings.VitessSettings section of config instead and why you chose the top level config?
Contributor
Author
That's a good question @nickcanz. I think that's probably a better way to go. The only drawback is having to set the timeout per cluster, but someone is going to need that one day |
Contributor
Author
nickcanz
approved these changes
Apr 29, 2020
nickcanz
left a comment
There was a problem hiding this comment.
👍 and I like the new signature for the ParseTablets function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Vitess config param
TimeoutSecsto Freno (default 5 seconds)This new config param controls how long Freno will wait for the Vitess API to return tablet information
cc @drogart / @nickcanz / @gtowey