feat(storage): Fix the bucket name not found error #15274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15274 +/- ##
=======================================
Coverage 92.90% 92.91%
=======================================
Files 2401 2401
Lines 216443 216443
=======================================
+ Hits 201095 201100 +5
+ Misses 15348 15343 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scotthart
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @bajajneha27 and @ddelgrosso1)
google/cloud/storage/internal/async/connection_impl.cc line 309 at r1 (raw file):
future<StatusOr<std::unique_ptr<storage_experimental::AsyncWriterConnection>>> AsyncConnectionImpl::AppendableObjectUploadImpl(AppendableUploadParams p) { auto current = internal::MakeImmutableOptions(p.options);
It looks like the std::move(p.options) can stay. As far as I can tell, it's only the p.request that is read a second time in this function.
Code quote:
(p.optionsd08c8aa to
1f37992
Compare
v-pratap
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @bajajneha27, @ddelgrosso1, and @scotthart)
google/cloud/storage/internal/async/connection_impl.cc line 309 at r1 (raw file):
Previously, scotthart (Scott Hart) wrote…
It looks like the std::move(p.options) can stay. As far as I can tell, it's only the p.request that is read a second time in this function.
Done.
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bajajneha27 and @ddelgrosso1)
1f37992 to
81234b1
Compare
81234b1 to
520c466
Compare
We are getting the bucket not found error on finalization of ResumeAppendableObject because we are using the variable after moving them.
This change is