Skip to content

fix(storage): append object spec should only be set in the first request #15831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scotthart merged 1 commit into from
Dec 17, 2025
Merged

fix(storage): append object spec should only be set in the first request #15831

scotthart merged 1 commit into from
Dec 17, 2025
+38 −89

Conversation

@v-pratap
Copy link
Contributor

@v-pratap v-pratap commented Dec 15, 2025

In some edge cases we are getting the error: "INVALID_ARGUMENT: The 'append_object_spec' must only be specified on the first request."

I was not able repro this, but most likely this is causing the issue, raising this PR to mitigate the issue.

@v-pratap v-pratap requested review from a team as code owners December 15, 2025 14:39
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Dec 15, 2025
@gemini-code-assist
Copy link

gemini-code-assist bot commented Dec 15, 2025

Summary of Changes

Hello @v-pratap, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a targeted fix to prevent an INVALID_ARGUMENT error that can occur in specific edge cases within the asynchronous writer connection for Google Cloud Storage. The change ensures that a particular request parameter, append_object_spec, is correctly handled only on the first request, as required by the API. Accompanying unit tests have been refined to validate this precise behavior and maintain code integrity.

Highlights

  • Fix for INVALID_ARGUMENT error: The pull request addresses an 'INVALID_ARGUMENT: The 'append_object_spec' must only be specified on the first request' error by ensuring that the append_object_spec's write_handle is only set during the initial request in the AsyncWriterConnectionImpl::MakeRequest() method.
  • Refactored Test Cases: Existing test cases in async/writer_connection_impl_test.cc have been updated and simplified to align with the corrected behavior. Specifically, WriteHandleIsUpdatedAfterQuery was renamed to ResumeWithHandle and WriteHandleIsUpdatedAfterResume was renamed to QueryUpdatesHandle, with their internal logic adjusted to reflect the single-request append_object_spec constraint.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 15, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where append_object_spec was incorrectly included in subsequent requests of a BidiWriteObject stream, leading to an INVALID_ARGUMENT error. The fix correctly ensures that append_object_spec is only set on the first request. The accompanying test changes refactor and simplify existing tests, improving their clarity and focus. The core logic change is correct, and the existing test suite provides sufficient coverage for this fix. The changes are well-implemented and effectively resolve the reported bug.

@codecov
Copy link

codecov bot commented Dec 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (18c06b5) to head (e691510).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15831      +/-   ##
==========================================
- Coverage   92.95%   92.94%   -0.01%     
==========================================
  Files        2458     2458              
  Lines      227588   227552      -36     
==========================================
- Hits       211552   211501      -51     
- Misses      16036    16051      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@v-pratap v-pratap requested a review from bajajneha27 December 16, 2025 06:47
@scotthart scotthart merged commit 76c0a0e into googleapis:main Dec 17, 2025
66 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bajajneha27 bajajneha27 bajajneha27 approved these changes

@scotthart scotthart scotthart approved these changes

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@shubham-up-47 shubham-up-47 shubham-up-47 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@v-pratap @bajajneha27 @scotthart @shubham-up-47