enable single-click selection for reactive Plotly charts#8782
Merged
mscolnick merged 3 commits intoApr 2, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enables single-click selection reactivity for additional Plotly trace types by extracting click payloads into the same selection shape used by box/lasso selection, and updates related frontend/docs.
Changes:
- Added shared Plotly selection utilities (
extractClickSelection,extractPoints,extractIndices) and wiredonClickto produce selection payloads for supported traces. - Updated Plotly plugin selection handling to use the shared helpers for both click and box/lasso selection flows.
- Adjusted Slider input behavior/tests and updated Plotly docs to mention histogram support.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/plugins/impl/plotly/selection.ts | New helper module for extracting click-selection payloads and normalizing point/index data. |
| frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx | Uses the new helpers to support click-based selection and to normalize indices for selection events. |
| frontend/src/plugins/impl/SliderPlugin.tsx | Changes NumberField path to always call setValue (regardless of debounce). |
| frontend/src/plugins/impl/tests/SliderPlugin.test.tsx | Adds/updates slider tests around debounce and editable input behavior. |
| docs/api/plotting.md | Updates docs to mention histogram support in reactive Plotly selections. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@axsseldz sorry we missed the review on this. is this good for a review still? |
Contributor
Author
hey @mscolnick ill resolve the conflicts and let you know asap(: |
marimo-team#8682) When `debounce=True` and `include_input=True` are set on a slider, editing the numeric input does not trigger cell execution. This fixes the issue by forcing the NumberField's onChange to immediately setValue regardless of if the parent slider is configured with debounce, since numeric input edit events are explicitly requested by the user. Fixes marimo-team#8677 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
e0337f6 to
0ea7306
Compare
0ea7306 to
9678b59
Compare
mscolnick
approved these changes
Apr 2, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.22.1-dev28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Follow-up to #8490 and #8489
Add single-click selection support for Plotly scatter, scattergl, and histogram charts.
🔍 Description of Changes
📋 Checklist
CC: @mscolnick @nojaf