add slides minimap#9097
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a slides minimap (thumbnail list) to the slides layout to improve navigation and enable slide reordering.
Changes:
- Introduces a
SlidesMinimapcomponent with thumbnail rendering and drag-to-reorder support. - Adds a new cell reducer action (
moveCellToIndex) and maps it to document changes for persistence/sync. - Refactors slide rendering into a shared
Slidecomponent and wires slide ↔ minimap active state.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/core/cells/document-changes.ts | Treats moveCellToIndex as a reorder/config change emitter for document syncing. |
| frontend/src/core/cells/cells.ts | Adds moveCellToIndex reducer logic to reorder cells by index/column. |
| frontend/src/core/cells/tests/cells.test.ts | Adds test coverage for moveCellToIndex (same column, across columns, no-ops). |
| frontend/src/components/slides/slides-component.tsx | Adds controlled active index support and reports active index changes. |
| frontend/src/components/slides/slide.tsx | Extracts slide rendering into a memoized Slide component. |
| frontend/src/components/slides/minimap.tsx | Implements the minimap UI + drag/drop reordering logic and active-slide scrolling. |
| frontend/src/components/editor/renderers/slides-layout/slides-layout.tsx | Integrates minimap into slides layout and keeps active slide state in sync. |
Bundle ReportChanges will increase total bundle size by 12.13kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: marimo-esmAssets Changed:
Files in
Files in
Files in
|
mscolnick
previously approved these changes
Apr 9, 2026
mscolnick
left a comment
Contributor
There was a problem hiding this comment.
very clean, nice stuff
mscolnick
reviewed
Apr 9, 2026
mscolnick
reviewed
Apr 9, 2026
| }; | ||
| } | ||
|
|
||
| function resolveDropTarget({ |
Contributor
There was a problem hiding this comment.
could be nice to add some snapshot tests for this and projectDropTarget
Member
Author
There was a problem hiding this comment.
added some unit tests for those functions, don't think snapshot tests are necessary for testing the logic (could be wrong).
Member
|
🚀 looks great! |
mscolnick
approved these changes
Apr 10, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.1-dev8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Tested with light, medium and a heavy notebook (40+ cells with a lot of tables)
Screen.Recording.2026-04-08.at.6.46.33.PM.mov
📋 Pre-Review Checklist
✅ Merge Checklist