Mark DuckDb INET type (from inet extension) as unknown type#9384
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Pull request overview
This PR updates Marimo’s DuckDB dataset introspection to treat DuckDB’s INET (from the inet extension) as a known-but-unsupported/unknown data type, preventing warning spam, and expands test coverage for additional string type aliases.
Changes:
- Classify DuckDB
inetas an"unknown"type in_db_type_to_data_type(no warning emitted). - Add/expand test assertions for additional DuckDB string type aliases (
char,bpchar,string,uuid) and forinet.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
marimo/_data/get_datasets.py |
Adds inet to the set of DuckDB types explicitly mapped to "unknown" to avoid warning logs. |
tests/_data/test_get_datasets.py |
Extends _db_type_to_data_type tests to cover more string aliases and the inet extension type. |
There was a problem hiding this comment.
No issues found across 2 files
Architecture diagram
sequenceDiagram
participant UI as Marimo Frontend
participant DS as Dataset Service (get_datasets.py)
participant DB as DuckDB Engine
participant Ext as DuckDB INET Extension
Note over UI,Ext: Data Discovery Flow
UI->>DS: Request schema/metadata
DS->>DB: Query table/column metadata
opt If INET extension is loaded
DB->>Ext: Resolve custom types
end
DB-->>DS: Return column types (e.g., 'inet', 'uuid', 'varchar')
Note over DS: NEW: Type Classification Logic
DS->>DS: _db_type_to_data_type(column_type)
alt Type is known string (uuid, char, bpchar, etc.)
DS->>DS: Map to "string"
else Type is in _UNKNOWN_TYPES (row, geometry, inet, null)
DS->>DS: CHANGED: Map 'inet' to "unknown"
else Standard types
DS->>DS: Map to numeric/boolean/datetime
end
DS-->>UI: Return normalized schema (JSON)
UI->>UI: Render Data Explorer (no warnings)
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.4-dev7 |
📝 Summary
When using INET extension for DuckDB, I got a warning about inet type:
I marked this type as 'unknown' and updated tests (also for string types)
✅ Merge Checklist