hide add cell toolbar when show-chrome is false#9487
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
approved these changes
May 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses embedded edit-mode notebooks where show-chrome=false hides the main editor chrome but previously still left the inline add-cell toolbar visible (Closes #9429). It extends the existing “hide controls” behavior so the add-cell buttons at the bottom of each column are also suppressed when chrome is hidden.
Changes:
- Propagate
hideControlsfromEditAppintoCellArray. - Conditionally hide the per-column
<AddCellButtons />footer whenhideControlsis enabled. - Update embedding documentation to clarify that
show-chrome=trueenables the add-cell toolbar.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/core/edit-app.tsx | Passes hideControls down to the cell renderer so embedded “no chrome” mode can suppress add-cell UI. |
| frontend/src/components/editor/renderers/cell-array.tsx | Adds hideControls plumbing and hides the column footer add-cell toolbar when requested. |
| docs/guides/publishing/playground.md | Documents that show-chrome=true includes the add-cell toolbar in editor controls. |
Comment on lines
136
to
141
| <CellArray | ||
| mode={viewState.mode} | ||
| userConfig={userConfig} | ||
| appConfig={appConfig} | ||
| hideControls={hideControls} | ||
| /> |
|
|
||
| To show editor controls (such as panels icons and the run button), use | ||
| the query parameter `show-chrome=true` | ||
| To show editor controls (such as panels icons, the run button, and the |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.6-dev23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #9429. Hides the Add cells buttons
📋 Pre-Review Checklist
✅ Merge Checklist