Skip to content

fix(frontend): skip /health checks for static notebooks#9498

Merged
mscolnick merged 1 commit into
mainfrom
ms/fix/skip-health-static
May 11, 2026
Merged

fix(frontend): skip /health checks for static notebooks#9498
mscolnick merged 1 commit into
mainfrom
ms/fix/skip-health-static

Conversation

@mscolnick

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 11, 2026 16:56
@vercel

vercel Bot commented May 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment May 11, 2026 4:58pm

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the frontend runtime health-check logic to avoid calling the server /health endpoint when running in a static notebook context (where no backend server exists), aligning health behavior with other serverless modes like WASM and Islands.

Changes:

  • Treat static notebooks as always healthy in RuntimeManager.isHealthy().
  • Import and use isStaticNotebook() to bypass /health fetches for static notebooks.

Comment thread frontend/src/core/runtime/runtime.ts
@mscolnick mscolnick added the bug Something isn't working label May 11, 2026
@mscolnick mscolnick merged commit 3be8cdf into main May 11, 2026
37 of 38 checks passed
@mscolnick mscolnick deleted the ms/fix/skip-health-static branch May 11, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants