Monomorphic flow nodes by ahejlsberg · Pull Request #57977 · microsoft/TypeScript

ahejlsberg · 2024-03-28T01:05:05Z

Experiment to observe the performance effects of monomorphic flow nodes.

typescript-bot · 2024-03-28T01:05:16Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

ahejlsberg · 2024-03-28T01:05:23Z

@typescript-bot test it

typescript-bot · 2024-03-28T01:05:26Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-03-28T01:28:02Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-03-28T01:30:53Z

@ahejlsberg Here are the results of running the user tests comparing main and refs/pull/57977/merge:

Everything looks good!

typescript-bot · 2024-03-28T01:35:11Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,671k (± 0.01%)}	_{296,457k (± 0.01%)}	_{+787k (+ 0.27%)}	_296,436k	_296,486k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.19%)}	_{2.66s (± 0.24%)}	_~	_2.65s	_2.67s	_{p=0.386 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.83s (± 1.60%)}	_~	_0.82s	_0.85s	_{p=0.277 n=6}
_{Check Time}	_{8.24s (± 0.25%)}	_{8.21s (± 0.28%)}	_{-0.03s (- 0.38%)}	_8.18s	_8.23s	_{p=0.029 n=6}
_{Emit Time}	_{7.05s (± 0.77%)}	_{7.02s (± 0.25%)}	_~	_6.99s	_7.04s	_{p=0.285 n=6}
_{Total Time}	_{18.79s (± 0.28%)}	_{18.72s (± 0.10%)}	_{-0.06s (- 0.35%)}	_18.69s	_18.75s	_{p=0.007 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,888k (± 1.02%)}	_{193,596k (± 0.97%)}	_~	_192,351k	_196,132k	_{p=0.378 n=6}
_{Parse Time}	_{1.64s (± 0.51%)}	_{1.65s (± 0.80%)}	_~	_1.63s	_1.67s	_{p=0.280 n=6}
_{Bind Time}	_{0.87s (± 0.86%)}	_{0.88s (± 1.18%)}	_{+0.01s (+ 1.53%)}	_0.87s	_0.90s	_{p=0.046 n=6}
_{Check Time}	_{11.24s (± 0.34%)}	_{11.30s (± 0.74%)}	_~	_11.23s	_11.44s	_{p=0.259 n=6}
_{Emit Time}	_{3.15s (± 0.47%)}	_{3.14s (± 0.60%)}	_~	_3.11s	_3.16s	_{p=0.511 n=6}
_{Total Time}	_{16.91s (± 0.25%)}	_{16.98s (± 0.55%)}	_~	_16.86s	_17.12s	_{p=0.126 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,409k (± 0.00%)}	_{348,488k (± 0.01%)}	_{+1,079k (+ 0.31%)}	_348,453k	_348,537k	_{p=0.005 n=6}
_{Parse Time}	_{2.97s (± 0.91%)}	_{2.99s (± 0.88%)}	_~	_2.96s	_3.02s	_{p=0.367 n=6}
_{Bind Time}	_{1.11s (± 0.57%)}	_{1.09s (± 0.47%)}	_{-0.02s (- 2.10%)}	_1.08s	_1.09s	_{p=0.004 n=6}
_{Check Time}	_{8.28s (± 0.58%)}	_{8.21s (± 0.45%)}	_{-0.07s (- 0.85%)}	_8.16s	_8.26s	_{p=0.037 n=6}
_{Emit Time}	_{4.85s (± 0.18%)}	_{4.84s (± 0.40%)}	_~	_4.82s	_4.87s	_{p=0.370 n=6}
_{Total Time}	_{17.21s (± 0.27%)}	_{17.13s (± 0.19%)}	_{-0.08s (- 0.47%)}	_17.10s	_17.18s	_{p=0.013 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,764k (± 0.01%)}	_{303,890k (± 0.00%)}	_{+1,126k (+ 0.37%)}	_303,876k	_303,903k	_{p=0.005 n=6}
_{Parse Time}	_{2.96s (± 0.84%)}	_{2.97s (± 0.63%)}	_~	_2.94s	_2.99s	_{p=0.936 n=6}
_{Bind Time}	_{1.47s (± 0.35%)}	_{1.45s (± 0.95%)}	_{-0.02s (- 1.24%)}	_1.44s	_1.48s	_{p=0.039 n=6}
_{Check Time}	_{9.24s (± 0.39%)}	_{9.17s (± 0.59%)}	_~	_9.11s	_9.25s	_{p=0.050 n=6}
_{Emit Time}	_{5.30s (± 0.36%)}	_{5.31s (± 0.74%)}	_~	_5.25s	_5.36s	_{p=0.745 n=6}
_{Total Time}	_{18.98s (± 0.26%)}	_{18.90s (± 0.07%)}	_{-0.08s (- 0.43%)}	_18.88s	_18.92s	_{p=0.005 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,062k (± 0.01%)}	_{510,778k (± 0.00%)}	_{+716k (+ 0.14%)}	_510,756k	_510,819k	_{p=0.005 n=6}
_{Parse Time}	_{2.65s (± 0.31%)}	_{2.67s (± 0.21%)}	_{+0.01s (+ 0.44%)}	_2.66s	_2.67s	_{p=0.025 n=6}
_{Bind Time}	_{0.99s (± 0.99%)}	_{0.98s (± 0.83%)}	_~	_0.97s	_0.99s	_{p=0.282 n=6}
_{Check Time}	_{17.39s (± 0.47%)}	_{17.39s (± 0.48%)}	_~	_17.29s	_17.49s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.04s (± 0.42%)}	_{21.03s (± 0.42%)}	_~	_20.93s	_21.14s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,744,403k (± 0.00%)}	_{1,746,098k (± 0.00%)}	_{+1,695k (+ 0.10%)}	_1,746,075k	_1,746,113k	_{p=0.005 n=6}
_{Parse Time}	_{7.78s (± 0.54%)}	_{7.81s (± 0.70%)}	_~	_7.76s	_7.90s	_{p=0.630 n=6}
_{Bind Time}	_{2.83s (± 0.49%)}	_{2.77s (± 1.89%)}	_~	_2.75s	_2.88s	_{p=0.060 n=6}
_{Check Time}	_{67.08s (± 0.58%)}	_{66.67s (± 0.35%)}	_~	_66.40s	_66.95s	_{p=0.091 n=6}
_{Emit Time}	_{0.16s (± 5.21%)}	_{0.15s (± 3.36%)}	_~	_0.15s	_0.16s	_{p=0.523 n=6}
_{Total Time}	_{77.84s (± 0.52%)}	_{77.41s (± 0.28%)}	_~	_77.15s	_77.71s	_{p=0.054 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,396,325k (± 0.04%)}	_{2,405,727k (± 0.03%)}	_{+9,401k (+ 0.39%)}	_2,405,172k	_2,406,649k	_{p=0.005 n=6}
_{Parse Time}	_{7.45s (± 0.67%)}	_{7.50s (± 1.16%)}	_~	_7.38s	_7.60s	_{p=0.261 n=6}
_{Bind Time}	_{2.76s (± 0.71%)}	_{2.77s (± 0.85%)}	_~	_2.73s	_2.80s	_{p=1.000 n=6}
_{Check Time}	_{49.27s (± 0.63%)}	_{49.02s (± 0.37%)}	_~	_48.82s	_49.26s	_{p=0.173 n=6}
_{Emit Time}	_{3.93s (± 1.45%)}	_{3.82s (± 1.95%)}	_{-0.11s (- 2.76%)}	_3.73s	_3.91s	_{p=0.045 n=6}
_{Total Time}	_{63.44s (± 0.45%)}	_{63.14s (± 0.30%)}	_~	_62.86s	_63.35s	_{p=0.093 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,837k (± 0.01%)}	_{416,967k (± 0.02%)}	_{+1,130k (+ 0.27%)}	_416,912k	_417,157k	_{p=0.005 n=6}
_{Parse Time}	_{4.10s (± 0.91%)}	_{4.15s (± 0.52%)}	_{+0.05s (+ 1.22%)}	_4.13s	_4.18s	_{p=0.030 n=6}
_{Bind Time}	_{1.59s (± 0.93%)}	_{1.61s (± 1.01%)}	_{+0.02s (+ 1.57%)}	_1.59s	_1.63s	_{p=0.036 n=6}
_{Check Time}	_{22.52s (± 0.36%)}	_{22.30s (± 0.48%)}	_{-0.22s (- 0.96%)}	_22.13s	_22.43s	_{p=0.010 n=6}
_{Emit Time}	_{1.70s (± 1.38%)}	_{1.71s (± 1.75%)}	_~	_1.67s	_1.75s	_{p=0.520 n=6}
_{Total Time}	_{29.90s (± 0.28%)}	_{29.77s (± 0.45%)}	_~	_29.53s	_29.91s	_{p=0.109 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,896,268k (± 0.00%)}	_{2,902,703k (± 0.00%)}	_{+6,435k (+ 0.22%)}	_2,902,512k	_2,902,831k	_{p=0.005 n=6}
_{Parse Time}	_{12.94s (± 0.27%)}	_{12.93s (± 0.30%)}	_~	_12.88s	_12.98s	_{p=0.518 n=6}
_{Bind Time}	_{4.14s (± 0.13%)}	_{4.12s (± 0.32%)}	_{-0.02s (- 0.56%)}	_4.10s	_4.13s	_{p=0.004 n=6}
_{Check Time}	_{72.29s (± 0.45%)}	_{71.74s (± 0.37%)}	_{-0.55s (- 0.76%)}	_71.33s	_72.12s	_{p=0.016 n=6}
_{Emit Time}	_{19.40s (± 0.82%)}	_{20.75s (± 9.72%)}	_~	_19.42s	_23.36s	_{p=0.128 n=6}
_{Total Time}	_{108.78s (± 0.33%)}	_{109.54s (± 1.88%)}	_~	_107.89s	_112.21s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,792k (± 0.01%)}	_{409,708k (± 0.01%)}	_{+916k (+ 0.22%)}	_409,604k	_409,759k	_{p=0.005 n=6}
_{Parse Time}	_{3.24s (± 0.30%)}	_{3.23s (± 0.64%)}	_~	_3.21s	_3.27s	_{p=0.405 n=6}
_{Bind Time}	_{1.40s (± 0.90%)}	_{1.40s (± 0.37%)}	_~	_1.39s	_1.40s	_{p=0.448 n=6}
_{Check Time}	_{14.28s (± 0.22%)}	_{14.20s (± 0.21%)}	_{-0.08s (- 0.54%)}	_14.16s	_14.24s	_{p=0.012 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.92s (± 0.19%)}	_{18.83s (± 0.19%)}	_{-0.09s (- 0.45%)}	_18.77s	_18.87s	_{p=0.008 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,414k (± 0.01%)}	_{514,996k (± 0.03%)}	_{+1,582k (+ 0.31%)}	_514,884k	_515,314k	_{p=0.005 n=6}
_{Parse Time}	_{3.97s (± 0.46%)}	_{4.04s (± 4.45%)}	_~	_3.95s	_4.41s	_{p=0.627 n=6}
_{Bind Time}	_{1.88s (± 1.40%)}	_{1.88s (± 0.81%)}	_~	_1.85s	_1.89s	_{p=1.000 n=6}
_{Check Time}	_{3.41s (± 0.58%)}	_{3.43s (± 1.41%)}	_~	_3.38s	_3.50s	_{p=0.806 n=6}
_{Emit Time}	_{0.08s (± 6.19%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.527 n=6}
_{Total Time}	_{9.35s (± 0.36%)}	_{9.44s (± 1.89%)}	_~	_9.31s	_9.78s	_{p=0.630 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-03-28T02:38:39Z

@ahejlsberg Here are the results of running the top 400 repos comparing main and refs/pull/57977/merge:

Everything looks good!

ahejlsberg · 2024-03-28T14:05:08Z

@typescript-bot perf test this faster

typescript-bot · 2024-03-28T14:05:11Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-03-28T14:39:05Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,590k (± 0.01%)}	_{296,432k (± 0.01%)}	_{+842k (+ 0.28%)}	_296,406k	_296,459k	_{p=0.005 n=6}
_{Parse Time}	_{3.93s (± 0.44%)}	_{3.94s (± 0.35%)}	_~	_3.92s	_3.95s	_{p=0.459 n=6}
_{Bind Time}	_{1.24s (± 1.11%)}	_{1.25s (± 0.88%)}	_~	_1.24s	_1.27s	_{p=0.111 n=6}
_{Check Time}	_{12.01s (± 0.31%)}	_{11.97s (± 0.32%)}	_~	_11.91s	_12.00s	_{p=0.145 n=6}
_{Emit Time}	_{10.45s (± 0.37%)}	_{10.43s (± 0.40%)}	_~	_10.37s	_10.47s	_{p=0.570 n=6}
_{Total Time}	_{27.63s (± 0.18%)}	_{27.58s (± 0.26%)}	_~	_27.48s	_27.67s	_{p=0.260 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,742k (± 0.73%)}	_{193,706k (± 0.94%)}	_{+965k (+ 0.50%)}	_192,387k	_196,139k	_{p=0.045 n=6}
_{Parse Time}	_{1.34s (± 1.13%)}	_{1.36s (± 0.72%)}	_~	_1.35s	_1.38s	_{p=0.059 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.74s (± 0.00%)}	_{+0.01s (+ 1.37%)}	_0.74s	_0.74s	_{p=0.001 n=6}
_{Check Time}	_{9.53s (± 0.41%)}	_{9.51s (± 0.35%)}	_~	_9.46s	_9.55s	_{p=0.574 n=6}
_{Emit Time}	_{2.63s (± 0.46%)}	_{2.63s (± 0.37%)}	_~	_2.62s	_2.64s	_{p=0.865 n=6}
_{Total Time}	_{14.23s (± 0.28%)}	_{14.24s (± 0.21%)}	_~	_14.20s	_14.28s	_{p=0.422 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,401k (± 0.01%)}	_{348,455k (± 0.01%)}	_{+1,054k (+ 0.30%)}	_348,420k	_348,468k	_{p=0.005 n=6}
_{Parse Time}	_{2.49s (± 0.34%)}	_{2.47s (± 0.85%)}	_~	_2.43s	_2.49s	_{p=0.109 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.93s (± 0.55%)}	_~	_0.93s	_0.94s	_{p=0.069 n=6}
_{Check Time}	_{7.02s (± 0.47%)}	_{6.92s (± 0.42%)}	_{-0.11s (- 1.52%)}	_6.89s	_6.97s	_{p=0.006 n=6}
_{Emit Time}	_{4.06s (± 0.40%)}	_{4.05s (± 0.51%)}	_~	_4.03s	_4.08s	_{p=0.869 n=6}
_{Total Time}	_{14.49s (± 0.28%)}	_{14.38s (± 0.36%)}	_{-0.12s (- 0.80%)}	_14.29s	_14.44s	_{p=0.008 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,773k (± 0.01%)}	_{303,921k (± 0.01%)}	_{+1,148k (+ 0.38%)}	_303,886k	_303,975k	_{p=0.005 n=6}
_{Parse Time}	_{2.41s (± 0.68%)}	_{2.42s (± 1.21%)}	_~	_2.37s	_2.45s	_{p=0.170 n=6}
_{Bind Time}	_{1.19s (± 0.63%)}	_{1.20s (± 1.33%)}	_~	_1.18s	_1.22s	_{p=0.136 n=6}
_{Check Time}	_{7.54s (± 0.31%)}	_{7.49s (± 0.35%)}	_{-0.05s (- 0.73%)}	_7.44s	_7.52s	_{p=0.008 n=6}
_{Emit Time}	_{4.27s (± 0.74%)}	_{4.28s (± 0.54%)}	_~	_4.25s	_4.31s	_{p=0.292 n=6}
_{Total Time}	_{15.41s (± 0.21%)}	_{15.39s (± 0.25%)}	_~	_15.34s	_15.43s	_{p=0.685 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,051k (± 0.00%)}	_{510,814k (± 0.01%)}	_{+764k (+ 0.15%)}	_510,764k	_510,858k	_{p=0.005 n=6}
_{Parse Time}	_{2.65s (± 0.56%)}	_{2.66s (± 0.39%)}	_~	_2.65s	_2.68s	_{p=0.101 n=6}
_{Bind Time}	_{0.99s (± 1.11%)}	_{0.98s (± 0.42%)}	_~	_0.98s	_0.99s	_{p=0.090 n=6}
_{Check Time}	_{17.33s (± 0.35%)}	_{17.33s (± 0.55%)}	_~	_17.21s	_17.43s	_{p=0.748 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.97s (± 0.18%)}	_{20.98s (± 0.43%)}	_~	_20.87s	_21.08s	_{p=0.629 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,744,675k (± 0.00%)}	_{1,746,323k (± 0.00%)}	_{+1,648k (+ 0.09%)}	_1,746,279k	_1,746,350k	_{p=0.005 n=6}
_{Parse Time}	_{6.60s (± 0.30%)}	_{6.61s (± 0.40%)}	_~	_6.56s	_6.64s	_{p=0.359 n=6}
_{Bind Time}	_{2.38s (± 0.78%)}	_{2.37s (± 0.56%)}	_~	_2.36s	_2.39s	_{p=0.448 n=6}
_{Check Time}	_{56.67s (± 0.53%)}	_{56.60s (± 0.45%)}	_~	_56.30s	_56.95s	_{p=0.936 n=6}
_{Emit Time}	_{0.13s (± 3.10%)}	_{0.13s (± 3.10%)}	_~	_0.13s	_0.14s	_{p=1.000 n=6}
_{Total Time}	_{65.78s (± 0.43%)}	_{65.71s (± 0.39%)}	_~	_65.39s	_66.07s	_{p=0.873 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,396,280k (± 0.04%)}	_{2,405,639k (± 0.04%)}	_{+9,360k (+ 0.39%)}	_2,404,293k	_2,406,787k	_{p=0.005 n=6}
_{Parse Time}	_{6.00s (± 0.76%)}	_{5.97s (± 0.82%)}	_~	_5.91s	_6.02s	_{p=0.295 n=6}
_{Bind Time}	_{2.26s (± 1.27%)}	_{2.27s (± 0.85%)}	_~	_2.24s	_2.30s	_{p=0.374 n=6}
_{Check Time}	_{39.76s (± 0.18%)}	_{39.48s (± 0.34%)}	_{-0.27s (- 0.69%)}	_39.33s	_39.64s	_{p=0.005 n=6}
_{Emit Time}	_{3.12s (± 1.32%)}	_{3.09s (± 2.25%)}	_~	_3.00s	_3.21s	_{p=0.261 n=6}
_{Total Time}	_{51.17s (± 0.24%)}	_{50.84s (± 0.19%)}	_{-0.34s (- 0.66%)}	_50.69s	_50.95s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,838k (± 0.01%)}	_{416,969k (± 0.01%)}	_{+1,131k (+ 0.27%)}	_416,913k	_417,010k	_{p=0.005 n=6}
_{Parse Time}	_{3.34s (± 0.73%)}	_{3.33s (± 0.88%)}	_~	_3.30s	_3.38s	_{p=0.463 n=6}
_{Bind Time}	_{1.29s (± 0.91%)}	_{1.33s (± 0.48%)}	_{+0.04s (+ 3.23%)}	_1.32s	_1.34s	_{p=0.004 n=6}
_{Check Time}	_{18.23s (± 0.33%)}	_{18.08s (± 0.27%)}	_{-0.15s (- 0.80%)}	_18.02s	_18.15s	_{p=0.010 n=6}
_{Emit Time}	_{1.36s (± 1.35%)}	_{1.36s (± 0.62%)}	_~	_1.34s	_1.36s	_{p=0.325 n=6}
_{Total Time}	_{24.22s (± 0.32%)}	_{24.10s (± 0.15%)}	_{-0.12s (- 0.50%)}	_24.05s	_24.15s	_{p=0.016 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,898,052k (± 0.00%)}	_{2,904,473k (± 0.00%)}	_{+6,422k (+ 0.22%)}	_2,904,364k	_2,904,580k	_{p=0.005 n=6}
_{Parse Time}	_{15.96s (± 0.47%)}	_{15.90s (± 0.20%)}	_~	_15.86s	_15.95s	_{p=0.199 n=6}
_{Bind Time}	_{5.01s (± 0.21%)}	_{5.24s (± 0.35%)}	_{🔻+0.23s (+ 4.63%)}	_5.21s	_5.26s	_{p=0.005 n=6}
_{Check Time}	_{87.16s (± 0.28%)}	_{86.69s (± 0.35%)}	_{-0.47s (- 0.54%)}	_86.33s	_87.19s	_{p=0.031 n=6}
_{Emit Time}	_{23.63s (± 0.37%)}	_{23.61s (± 0.77%)}	_~	_23.41s	_23.92s	_{p=0.630 n=6}
_{Total Time}	_{131.75s (± 0.18%)}	_{131.44s (± 0.17%)}	_~	_131.16s	_131.80s	_{p=0.054 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,980k (± 0.02%)}	_{409,833k (± 0.02%)}	_{+854k (+ 0.21%)}	_409,751k	_409,918k	_{p=0.005 n=6}
_{Parse Time}	_{4.79s (± 0.36%)}	_{4.79s (± 0.81%)}	_~	_4.73s	_4.82s	_{p=0.746 n=6}
_{Bind Time}	_{2.08s (± 1.11%)}	_{2.07s (± 1.17%)}	_~	_2.05s	_2.11s	_{p=0.250 n=6}
_{Check Time}	_{20.90s (± 0.54%)}	_{20.77s (± 0.34%)}	_{-0.13s (- 0.62%)}	_20.70s	_20.86s	_{p=0.030 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{27.77s (± 0.42%)}	_{27.63s (± 0.27%)}	_{-0.14s (- 0.52%)}	_27.54s	_27.72s	_{p=0.045 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,420k (± 0.01%)}	_{514,860k (± 0.01%)}	_{+1,440k (+ 0.28%)}	_514,803k	_514,919k	_{p=0.005 n=6}
_{Parse Time}	_{3.97s (± 0.53%)}	_{3.97s (± 0.53%)}	_~	_3.94s	_4.00s	_{p=0.872 n=6}
_{Bind Time}	_{1.89s (± 1.60%)}	_{1.88s (± 1.29%)}	_~	_1.84s	_1.90s	_{p=0.570 n=6}
_{Check Time}	_{3.43s (± 0.70%)}	_{3.43s (± 0.68%)}	_~	_3.39s	_3.46s	_{p=0.872 n=6}
_{Emit Time}	_{0.09s (± 5.95%)}	_{0.08s (± 6.19%)}	_~	_0.08s	_0.09s	_{p=0.311 n=6}
_{Total Time}	_{9.38s (± 0.59%)}	_{9.36s (± 0.46%)}	_~	_9.31s	_9.42s	_{p=0.629 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

ahejlsberg · 2024-03-28T16:26:22Z

@typescript-bot perf test this faster

typescript-bot · 2024-03-28T16:26:25Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

ahejlsberg · 2024-03-28T16:52:56Z

@typescript-bot perf test this faster

typescript-bot · 2024-03-28T16:53:00Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-03-28T17:00:12Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,619k (± 0.01%)}	_{296,252k (± 0.01%)}	_{+634k (+ 0.21%)}	_296,227k	_296,293k	_{p=0.005 n=6}
_{Parse Time}	_{3.21s (± 0.51%)}	_{3.21s (± 0.46%)}	_~	_3.19s	_3.23s	_{p=0.624 n=6}
_{Bind Time}	_{1.00s (± 0.82%)}	_{0.99s (± 1.56%)}	_~	_0.98s	_1.01s	_{p=0.281 n=6}
_{Check Time}	_{9.72s (± 0.31%)}	_{9.71s (± 0.23%)}	_~	_9.67s	_9.73s	_{p=0.629 n=6}
_{Emit Time}	_{8.39s (± 0.35%)}	_{8.38s (± 0.29%)}	_~	_8.35s	_8.41s	_{p=0.464 n=6}
_{Total Time}	_{22.31s (± 0.17%)}	_{22.29s (± 0.12%)}	_~	_22.25s	_22.32s	_{p=0.368 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,704k (± 0.75%)}	_{193,843k (± 0.93%)}	_{+1,139k (+ 0.59%)}	_192,630k	_196,219k	_{p=0.030 n=6}
_{Parse Time}	_{1.35s (± 0.98%)}	_{1.35s (± 0.56%)}	_~	_1.34s	_1.36s	_{p=0.448 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.74s (± 0.00%)}	_{+0.01s (+ 1.37%)}	_0.74s	_0.74s	_{p=0.001 n=6}
_{Check Time}	_{9.55s (± 0.71%)}	_{9.63s (± 0.35%)}	_~	_9.57s	_9.66s	_{p=0.090 n=6}
_{Emit Time}	_{2.62s (± 0.56%)}	_{2.63s (± 0.42%)}	_~	_2.61s	_2.64s	_{p=0.186 n=6}
_{Total Time}	_{14.25s (± 0.44%)}	_{14.35s (± 0.17%)}	_{+0.10s (+ 0.70%)}	_14.30s	_14.37s	_{p=0.029 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,380k (± 0.01%)}	_{348,418k (± 0.01%)}	_{+1,038k (+ 0.30%)}	_348,395k	_348,454k	_{p=0.005 n=6}
_{Parse Time}	_{2.48s (± 0.44%)}	_{2.49s (± 0.16%)}	_~	_2.48s	_2.49s	_{p=0.100 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.92s (± 0.00%)}	_{-0.01s (- 0.72%)}	_0.92s	_0.92s	_{p=0.025 n=6}
_{Check Time}	_{7.03s (± 0.23%)}	_{6.97s (± 0.36%)}	_{-0.05s (- 0.78%)}	_6.94s	_7.00s	_{p=0.007 n=6}
_{Emit Time}	_{4.06s (± 0.25%)}	_{4.05s (± 0.46%)}	_~	_4.04s	_4.09s	_{p=0.324 n=6}
_{Total Time}	_{14.49s (± 0.23%)}	_{14.43s (± 0.18%)}	_{-0.06s (- 0.41%)}	_14.38s	_14.45s	_{p=0.005 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,776k (± 0.01%)}	_{304,001k (± 0.01%)}	_{+1,225k (+ 0.40%)}	_303,950k	_304,073k	_{p=0.005 n=6}
_{Parse Time}	_{2.42s (± 1.00%)}	_{2.42s (± 0.77%)}	_~	_2.39s	_2.44s	_{p=0.413 n=6}
_{Bind Time}	_{1.19s (± 0.63%)}	_{1.19s (± 0.63%)}	_~	_1.18s	_1.20s	_{p=0.487 n=6}
_{Check Time}	_{7.52s (± 0.33%)}	_{7.54s (± 0.43%)}	_~	_7.49s	_7.57s	_{p=0.464 n=6}
_{Emit Time}	_{4.28s (± 0.74%)}	_{4.25s (± 0.69%)}	_~	_4.20s	_4.28s	_{p=0.092 n=6}
_{Total Time}	_{15.41s (± 0.28%)}	_{15.40s (± 0.43%)}	_~	_15.32s	_15.49s	_{p=0.810 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,039k (± 0.01%)}	_{510,574k (± 0.00%)}	_{+534k (+ 0.10%)}	_510,558k	_510,598k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.31%)}	_{2.67s (± 0.39%)}	_~	_2.65s	_2.68s	_{p=0.546 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{0.98s (± 0.77%)}	_{-0.02s (- 2.00%)}	_0.97s	_0.99s	_{p=0.004 n=6}
_{Check Time}	_{17.30s (± 0.38%)}	_{17.31s (± 0.31%)}	_~	_17.24s	_17.38s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.96s (± 0.30%)}	_{20.96s (± 0.26%)}	_~	_20.90s	_21.04s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,744,624k (± 0.00%)}	_{1,745,945k (± 0.00%)}	_{+1,321k (+ 0.08%)}	_1,745,935k	_1,745,963k	_{p=0.005 n=6}
_{Parse Time}	_{7.79s (± 0.42%)}	_{7.81s (± 0.63%)}	_~	_7.72s	_7.87s	_{p=0.261 n=6}
_{Bind Time}	_{2.82s (± 0.41%)}	_{2.78s (± 0.51%)}	_{-0.04s (- 1.36%)}	_2.76s	_2.80s	_{p=0.005 n=6}
_{Check Time}	_{66.44s (± 0.49%)}	_{66.72s (± 0.39%)}	_~	_66.33s	_66.97s	_{p=0.128 n=6}
_{Emit Time}	_{0.16s (± 3.29%)}	_{0.16s (± 3.29%)}	_~	_0.15s	_0.16s	_{p=1.000 n=6}
_{Total Time}	_{77.20s (± 0.45%)}	_{77.46s (± 0.33%)}	_~	_77.08s	_77.74s	_{p=0.230 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,396,152k (± 0.03%)}	_{2,402,666k (± 0.05%)}	_{+6,514k (+ 0.27%)}	_2,401,346k	_2,403,954k	_{p=0.005 n=6}
_{Parse Time}	_{4.98s (± 1.01%)}	_{5.02s (± 1.10%)}	_~	_4.95s	_5.11s	_{p=0.297 n=6}
_{Bind Time}	_{1.90s (± 0.77%)}	_{1.93s (± 1.25%)}	_{+0.03s (+ 1.67%)}	_1.91s	_1.97s	_{p=0.034 n=6}
_{Check Time}	_{33.87s (± 0.20%)}	_{33.85s (± 0.26%)}	_~	_33.74s	_33.95s	_{p=0.520 n=6}
_{Emit Time}	_{2.68s (± 1.17%)}	_{2.60s (± 2.48%)}	_~	_2.51s	_2.68s	_{p=0.054 n=6}
_{Total Time}	_{43.44s (± 0.23%)}	_{43.42s (± 0.36%)}	_~	_43.20s	_43.57s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,888k (± 0.02%)}	_{417,323k (± 0.01%)}	_{+1,435k (+ 0.35%)}	_417,296k	_417,353k	_{p=0.005 n=6}
_{Parse Time}	_{4.12s (± 0.87%)}	_{4.12s (± 0.52%)}	_~	_4.09s	_4.14s	_{p=1.000 n=6}
_{Bind Time}	_{1.59s (± 0.66%)}	_{1.62s (± 1.03%)}	_{+0.02s (+ 1.57%)}	_1.60s	_1.65s	_{p=0.014 n=6}
_{Check Time}	_{22.53s (± 0.20%)}	_{22.37s (± 0.31%)}	_{-0.16s (- 0.70%)}	_22.30s	_22.50s	_{p=0.013 n=6}
_{Emit Time}	_{1.68s (± 1.25%)}	_{1.68s (± 1.66%)}	_~	_1.65s	_1.71s	_{p=0.626 n=6}
_{Total Time}	_{29.92s (± 0.21%)}	_{29.80s (± 0.25%)}	_{-0.13s (- 0.42%)}	_29.70s	_29.93s	_{p=0.020 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,897,392k (± 0.00%)}	_{2,904,135k (± 0.00%)}	_{+6,743k (+ 0.23%)}	_2,903,912k	_2,904,250k	_{p=0.005 n=6}
_{Parse Time}	_{15.97s (± 0.27%)}	_{15.94s (± 0.37%)}	_~	_15.87s	_16.03s	_{p=0.297 n=6}
_{Bind Time}	_{5.04s (± 0.46%)}	_{5.02s (± 0.20%)}	_~	_5.01s	_5.03s	_{p=0.118 n=6}
_{Check Time}	_{87.58s (± 0.37%)}	_{87.43s (± 0.43%)}	_~	_86.94s	_88.05s	_{p=0.471 n=6}
_{Emit Time}	_{23.76s (± 0.88%)}	_{24.59s (± 7.68%)}	_~	_23.68s	_28.44s	_{p=0.298 n=6}
_{Total Time}	_{132.35s (± 0.33%)}	_{132.98s (± 1.65%)}	_~	_131.65s	_137.41s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,921k (± 0.03%)}	_{409,825k (± 0.01%)}	_{+904k (+ 0.22%)}	_409,756k	_409,895k	_{p=0.005 n=6}
_{Parse Time}	_{3.91s (± 0.38%)}	_{3.89s (± 0.52%)}	_~	_3.88s	_3.93s	_{p=0.154 n=6}
_{Bind Time}	_{1.68s (± 1.34%)}	_{1.67s (± 0.70%)}	_~	_1.65s	_1.68s	_{p=0.357 n=6}
_{Check Time}	_{16.85s (± 0.31%)}	_{16.78s (± 0.35%)}	_~	_16.71s	_16.86s	_{p=0.093 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.43s (± 0.24%)}	_{22.34s (± 0.17%)}	_{-0.09s (- 0.42%)}	_22.28s	_22.39s	_{p=0.010 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,520k (± 0.03%)}	_{514,646k (± 0.02%)}	_{+1,126k (+ 0.22%)}	_514,494k	_514,818k	_{p=0.005 n=6}
_{Parse Time}	_{4.89s (± 0.22%)}	_{4.87s (± 0.66%)}	_~	_4.81s	_4.89s	_{p=0.103 n=6}
_{Bind Time}	_{2.31s (± 1.53%)}	_{2.30s (± 0.91%)}	_~	_2.28s	_2.33s	_{p=0.627 n=6}
_{Check Time}	_{4.30s (± 0.50%)}	_{4.29s (± 0.54%)}	_~	_4.26s	_4.32s	_{p=0.869 n=6}
_{Emit Time}	_{0.11s (± 0.00%)}	_{0.11s (± 0.00%)}	_~	_0.11s	_0.11s	_{p=1.000 n=6}
_{Total Time}	_{11.62s (± 0.18%)}	_{11.58s (± 0.49%)}	_~	_11.49s	_11.67s	_{p=0.063 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-03-28T17:26:38Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,684k (± 0.01%)}	_{296,328k (± 0.01%)}	_{+644k (+ 0.22%)}	_296,291k	_296,359k	_{p=0.005 n=6}
_{Parse Time}	_{2.67s (± 0.21%)}	_{2.66s (± 0.70%)}	_~	_2.63s	_2.68s	_{p=0.865 n=6}
_{Bind Time}	_{0.84s (± 0.97%)}	_{0.84s (± 1.63%)}	_~	_0.82s	_0.85s	_{p=0.934 n=6}
_{Check Time}	_{8.22s (± 0.30%)}	_{8.25s (± 0.24%)}	_~	_8.22s	_8.27s	_{p=0.073 n=6}
_{Emit Time}	_{7.03s (± 0.44%)}	_{7.04s (± 0.37%)}	_~	_7.00s	_7.07s	_{p=0.747 n=6}
_{Total Time}	_{18.75s (± 0.22%)}	_{18.79s (± 0.21%)}	_~	_18.71s	_18.82s	_{p=0.291 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,725k (± 0.80%)}	_{193,742k (± 0.98%)}	_{+1,017k (+ 0.53%)}	_192,269k	_196,231k	_{p=0.031 n=6}
_{Parse Time}	_{1.36s (± 1.35%)}	_{1.35s (± 0.60%)}	_~	_1.35s	_1.37s	_{p=0.154 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.74s (± 0.00%)}	_{+0.01s (+ 1.37%)}	_0.74s	_0.74s	_{p=0.001 n=6}
_{Check Time}	_{9.54s (± 0.27%)}	_{9.58s (± 0.95%)}	_~	_9.46s	_9.67s	_{p=0.378 n=6}
_{Emit Time}	_{2.63s (± 0.24%)}	_{2.71s (± 4.36%)}	_~	_2.62s	_2.89s	_{p=0.157 n=6}
_{Total Time}	_{14.26s (± 0.28%)}	_{14.39s (± 1.25%)}	_~	_14.19s	_14.61s	_{p=0.261 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,413k (± 0.00%)}	_{348,441k (± 0.01%)}	_{+1,028k (+ 0.30%)}	_348,420k	_348,474k	_{p=0.005 n=6}
_{Parse Time}	_{3.00s (± 1.27%)}	_{3.00s (± 0.67%)}	_~	_2.97s	_3.02s	_{p=0.686 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_{1.10s (± 0.47%)}	_{-0.01s (- 0.75%)}	_1.10s	_1.11s	_{p=0.022 n=6}
_{Check Time}	_{8.31s (± 0.40%)}	_{8.23s (± 0.47%)}	_{-0.08s (- 0.94%)}	_8.18s	_8.28s	_{p=0.008 n=6}
_{Emit Time}	_{4.85s (± 0.44%)}	_{4.85s (± 0.57%)}	_~	_4.83s	_4.90s	_{p=1.000 n=6}
_{Total Time}	_{17.27s (± 0.30%)}	_{17.18s (± 0.38%)}	_{-0.08s (- 0.48%)}	_17.13s	_17.31s	_{p=0.045 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,786k (± 0.01%)}	_{303,988k (± 0.01%)}	_{+1,202k (+ 0.40%)}	_303,942k	_304,035k	_{p=0.005 n=6}
_{Parse Time}	_{2.40s (± 0.43%)}	_{2.42s (± 0.92%)}	_~	_2.39s	_2.45s	_{p=0.059 n=6}
_{Bind Time}	_{1.19s (± 0.68%)}	_{1.18s (± 0.54%)}	_{-0.01s (- 1.12%)}	_1.17s	_1.19s	_{p=0.023 n=6}
_{Check Time}	_{7.50s (± 0.48%)}	_{7.53s (± 0.39%)}	_~	_7.50s	_7.58s	_{p=0.171 n=6}
_{Emit Time}	_{4.26s (± 0.74%)}	_{4.27s (± 0.58%)}	_~	_4.24s	_4.30s	_{p=0.871 n=6}
_{Total Time}	_{15.35s (± 0.40%)}	_{15.39s (± 0.16%)}	_~	_15.36s	_15.42s	_{p=0.102 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,059k (± 0.01%)}	_{510,578k (± 0.00%)}	_{+518k (+ 0.10%)}	_510,565k	_510,588k	_{p=0.005 n=6}
_{Parse Time}	_{2.67s (± 0.24%)}	_{2.66s (± 0.50%)}	_~	_2.64s	_2.68s	_{p=0.081 n=6}
_{Bind Time}	_{0.99s (± 0.64%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.718 n=6}
_{Check Time}	_{17.34s (± 0.32%)}	_{17.31s (± 0.25%)}	_~	_17.26s	_17.37s	_{p=0.332 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.00s (± 0.27%)}	_{20.96s (± 0.20%)}	_~	_20.91s	_21.02s	_{p=0.334 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,744,643k (± 0.00%)}	_{1,745,919k (± 0.00%)}	_{+1,276k (+ 0.07%)}	_1,745,870k	_1,745,962k	_{p=0.005 n=6}
_{Parse Time}	_{6.62s (± 0.24%)}	_{6.59s (± 0.68%)}	_~	_6.55s	_6.67s	_{p=0.086 n=6}
_{Bind Time}	_{2.38s (± 0.58%)}	_{2.33s (± 0.45%)}	_{-0.05s (- 2.10%)}	_2.32s	_2.35s	_{p=0.005 n=6}
_{Check Time}	_{56.77s (± 0.48%)}	_{56.85s (± 0.64%)}	_~	_56.38s	_57.27s	_{p=0.810 n=6}
_{Emit Time}	_{0.13s (± 3.87%)}	_{0.13s (± 3.10%)}	_~	_0.13s	_0.14s	_{p=0.595 n=6}
_{Total Time}	_{65.91s (± 0.43%)}	_{65.91s (± 0.57%)}	_~	_65.40s	_66.32s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,396,215k (± 0.03%)}	_{2,403,535k (± 0.03%)}	_{+7,320k (+ 0.31%)}	_2,402,694k	_2,404,514k	_{p=0.005 n=6}
_{Parse Time}	_{5.97s (± 0.77%)}	_{5.98s (± 0.63%)}	_~	_5.93s	_6.02s	_{p=1.000 n=6}
_{Bind Time}	_{2.26s (± 1.45%)}	_{2.27s (± 0.45%)}	_~	_2.26s	_2.29s	_{p=0.106 n=6}
_{Check Time}	_{39.83s (± 0.23%)}	_{39.85s (± 0.28%)}	_~	_39.74s	_40.04s	_{p=0.689 n=6}
_{Emit Time}	_{3.16s (± 2.18%)}	_{3.07s (± 2.42%)}	_~	_2.98s	_3.16s	_{p=0.054 n=6}
_{Total Time}	_{51.23s (± 0.29%)}	_{51.18s (± 0.27%)}	_~	_51.04s	_51.43s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,831k (± 0.01%)}	_{417,381k (± 0.01%)}	_{+1,550k (+ 0.37%)}	_417,304k	_417,464k	_{p=0.005 n=6}
_{Parse Time}	_{4.12s (± 0.85%)}	_{4.12s (± 1.03%)}	_~	_4.07s	_4.18s	_{p=0.872 n=6}
_{Bind Time}	_{1.59s (± 0.86%)}	_{1.63s (± 1.21%)}	_{+0.03s (+ 1.99%)}	_1.60s	_1.66s	_{p=0.014 n=6}
_{Check Time}	_{22.46s (± 0.49%)}	_{22.50s (± 0.70%)}	_~	_22.32s	_22.74s	_{p=0.630 n=6}
_{Emit Time}	_{1.70s (± 1.50%)}	_{1.70s (± 1.55%)}	_~	_1.66s	_1.74s	_{p=1.000 n=6}
_{Total Time}	_{29.88s (± 0.43%)}	_{29.94s (± 0.70%)}	_~	_29.73s	_30.28s	_{p=0.687 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,898,107k (± 0.00%)}	_{2,904,840k (± 0.00%)}	_{+6,733k (+ 0.23%)}	_2,904,687k	_2,904,932k	_{p=0.005 n=6}
_{Parse Time}	_{15.92s (± 0.33%)}	_{15.89s (± 0.43%)}	_~	_15.82s	_15.99s	_{p=0.572 n=6}
_{Bind Time}	_{5.00s (± 0.37%)}	_{4.97s (± 0.55%)}	_~	_4.94s	_5.00s	_{p=0.102 n=6}
_{Check Time}	_{86.73s (± 0.23%)}	_{87.08s (± 0.51%)}	_~	_86.57s	_87.58s	_{p=0.423 n=6}
_{Emit Time}	_{23.62s (± 0.64%)}	_{25.18s (± 9.75%)}	_~	_23.43s	_28.52s	_{p=0.378 n=6}
_{Total Time}	_{131.28s (± 0.21%)}	_{133.13s (± 2.07%)}	_~	_130.97s	_136.67s	_{p=0.423 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,885k (± 0.02%)}	_{409,873k (± 0.03%)}	_{+988k (+ 0.24%)}	_409,767k	_410,069k	_{p=0.005 n=6}
_{Parse Time}	_{3.88s (± 0.62%)}	_{3.88s (± 0.50%)}	_~	_3.85s	_3.91s	_{p=0.506 n=6}
_{Bind Time}	_{1.68s (± 0.69%)}	_{1.67s (± 1.49%)}	_~	_1.63s	_1.70s	_{p=0.411 n=6}
_{Check Time}	_{16.83s (± 0.28%)}	_{16.78s (± 0.22%)}	_~	_16.72s	_16.82s	_{p=0.170 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.39s (± 0.18%)}	_{22.33s (± 0.22%)}	_{-0.06s (- 0.28%)}	_22.27s	_22.42s	_{p=0.044 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,486k (± 0.03%)}	_{514,654k (± 0.02%)}	_{+1,168k (+ 0.23%)}	_514,512k	_514,840k	_{p=0.005 n=6}
_{Parse Time}	_{3.97s (± 0.59%)}	_{3.98s (± 0.65%)}	_~	_3.94s	_4.02s	_{p=0.809 n=6}
_{Bind Time}	_{1.88s (± 0.97%)}	_{1.88s (± 1.03%)}	_~	_1.86s	_1.91s	_{p=0.745 n=6}
_{Check Time}	_{3.43s (± 0.62%)}	_{3.43s (± 0.70%)}	_~	_3.39s	_3.46s	_{p=0.627 n=6}
_{Emit Time}	_{0.09s (± 9.41%)}	_{0.09s (± 6.44%)}	_~	_0.08s	_0.09s	_{p=0.796 n=6}
_{Total Time}	_{9.38s (± 0.46%)}	_{9.38s (± 0.62%)}	_~	_9.28s	_9.45s	_{p=0.872 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

ahejlsberg · 2024-03-31T22:14:27Z

@typescript-bot perf test this faster

typescript-bot · 2024-03-31T22:14:30Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

ahejlsberg · 2024-04-02T14:16:24Z

@typescript-bot perf test this faster

typescript-bot · 2024-04-02T14:16:28Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-04-02T14:19:10Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-04-02T14:23:01Z

@ahejlsberg Here are the results of running the user tests comparing main and refs/pull/57977/merge:

Everything looks good!

typescript-bot · 2024-04-02T14:30:54Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,693k (± 0.01%)}	_{295,941k (± 0.01%)}	_{+248k (+ 0.08%)}	_295,876k	_295,992k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.31%)}	_{2.65s (± 0.48%)}	_~	_2.63s	_2.66s	_{p=0.293 n=6}
_{Bind Time}	_{0.84s (± 0.97%)}	_{0.83s (± 1.60%)}	_~	_0.82s	_0.85s	_{p=0.185 n=6}
_{Check Time}	_{8.26s (± 0.28%)}	_{8.22s (± 0.45%)}	_~	_8.17s	_8.27s	_{p=0.125 n=6}
_{Emit Time}	_{7.05s (± 0.48%)}	_{7.04s (± 0.35%)}	_~	_7.00s	_7.07s	_{p=0.936 n=6}
_{Total Time}	_{18.80s (± 0.23%)}	_{18.74s (± 0.17%)}	_{-0.06s (- 0.32%)}	_18.70s	_18.79s	_{p=0.024 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,299k (± 0.92%)}	_{193,805k (± 1.00%)}	_~	_191,975k	_195,636k	_{p=0.575 n=6}
_{Parse Time}	_{1.37s (± 0.92%)}	_{1.36s (± 1.23%)}	_~	_1.34s	_1.38s	_{p=0.315 n=6}
_{Bind Time}	_{0.73s (± 0.56%)}	_{0.73s (± 0.71%)}	_~	_0.72s	_0.73s	_{p=0.595 n=6}
_{Check Time}	_{9.55s (± 0.45%)}	_{9.51s (± 0.92%)}	_~	_9.38s	_9.60s	_{p=0.686 n=6}
_{Emit Time}	_{2.63s (± 0.31%)}	_{2.63s (± 0.57%)}	_~	_2.61s	_2.65s	_{p=0.357 n=6}
_{Total Time}	_{14.28s (± 0.33%)}	_{14.22s (± 0.55%)}	_~	_14.11s	_14.30s	_{p=0.228 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,415k (± 0.00%)}	_{347,842k (± 0.01%)}	_{+428k (+ 0.12%)}	_347,807k	_347,876k	_{p=0.005 n=6}
_{Parse Time}	_{2.49s (± 0.55%)}	_{2.49s (± 0.55%)}	_~	_2.47s	_2.51s	_{p=1.000 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.91s (± 0.60%)}	_{-0.03s (- 2.86%)}	_0.90s	_0.91s	_{p=0.003 n=6}
_{Check Time}	_{7.02s (± 0.46%)}	_{6.96s (± 0.31%)}	_{-0.06s (- 0.93%)}	_6.94s	_7.00s	_{p=0.007 n=6}
_{Emit Time}	_{4.07s (± 0.63%)}	_{4.08s (± 0.59%)}	_~	_4.04s	_4.11s	_{p=0.466 n=6}
_{Total Time}	_{14.52s (± 0.24%)}	_{14.43s (± 0.21%)}	_{-0.09s (- 0.60%)}	_14.39s	_14.48s	_{p=0.006 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,779k (± 0.01%)}	_{303,103k (± 0.00%)}	_{+324k (+ 0.11%)}	_303,076k	_303,116k	_{p=0.005 n=6}
_{Parse Time}	_{2.41s (± 0.93%)}	_{2.41s (± 0.69%)}	_~	_2.39s	_2.43s	_{p=0.621 n=6}
_{Bind Time}	_{1.21s (± 0.43%)}	_{1.18s (± 0.44%)}	_{🟩-0.04s (- 3.02%)}	_1.17s	_1.18s	_{p=0.004 n=6}
_{Check Time}	_{7.53s (± 0.36%)}	_{7.46s (± 0.60%)}	_{-0.06s (- 0.82%)}	_7.41s	_7.53s	_{p=0.024 n=6}
_{Emit Time}	_{4.27s (± 0.55%)}	_{4.25s (± 0.89%)}	_~	_4.21s	_4.31s	_{p=0.685 n=6}
_{Total Time}	_{15.42s (± 0.15%)}	_{15.31s (± 0.32%)}	_{-0.11s (- 0.71%)}	_15.23s	_15.36s	_{p=0.005 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,055k (± 0.00%)}	_{510,592k (± 0.01%)}	_{+537k (+ 0.11%)}	_510,533k	_510,623k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.24%)}	_{2.66s (± 0.19%)}	_~	_2.66s	_2.67s	_{p=0.386 n=6}
_{Bind Time}	_{0.99s (± 0.82%)}	_{0.98s (± 1.67%)}	_~	_0.97s	_1.01s	_{p=0.323 n=6}
_{Check Time}	_{17.32s (± 0.49%)}	_{17.32s (± 0.59%)}	_~	_17.23s	_17.52s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.97s (± 0.38%)}	_{20.98s (± 0.47%)}	_~	_20.88s	_21.16s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,745,025k (± 0.00%)}	_{1,745,996k (± 0.00%)}	_{+970k (+ 0.06%)}	_1,745,967k	_1,746,029k	_{p=0.005 n=6}
_{Parse Time}	_{7.79s (± 0.39%)}	_{7.84s (± 1.65%)}	_~	_7.73s	_8.09s	_{p=0.628 n=6}
_{Bind Time}	_{2.82s (± 0.43%)}	_{2.79s (± 3.13%)}	_~	_2.73s	_2.97s	_{p=0.064 n=6}
_{Check Time}	_{66.96s (± 0.37%)}	_{66.86s (± 0.33%)}	_~	_66.57s	_67.10s	_{p=0.575 n=6}
_{Emit Time}	_{0.16s (± 4.75%)}	_{0.16s (± 3.29%)}	_~	_0.15s	_0.16s	_{p=0.784 n=6}
_{Total Time}	_{77.73s (± 0.31%)}	_{77.65s (± 0.24%)}	_~	_77.33s	_77.80s	_{p=0.376 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,400,635k (± 0.03%)}	_{2,405,519k (± 0.04%)}	_{+4,884k (+ 0.20%)}	_2,404,363k	_2,406,993k	_{p=0.005 n=6}
_{Parse Time}	_{7.44s (± 1.09%)}	_{7.46s (± 1.02%)}	_~	_7.36s	_7.58s	_{p=0.689 n=6}
_{Bind Time}	_{2.78s (± 0.44%)}	_{2.75s (± 0.78%)}	_{-0.03s (- 1.20%)}	_2.73s	_2.78s	_{p=0.019 n=6}
_{Check Time}	_{49.37s (± 0.38%)}	_{49.11s (± 0.34%)}	_{-0.26s (- 0.52%)}	_48.83s	_49.28s	_{p=0.045 n=6}
_{Emit Time}	_{3.94s (± 1.08%)}	_{3.87s (± 2.81%)}	_~	_3.74s	_3.98s	_{p=0.689 n=6}
_{Total Time}	_{63.55s (± 0.41%)}	_{63.21s (± 0.30%)}	_{-0.35s (- 0.54%)}	_62.97s	_63.39s	_{p=0.030 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,207k (± 0.01%)}	_{416,251k (± 0.01%)}	_~	_416,210k	_416,330k	_{p=0.298 n=6}
_{Parse Time}	_{3.30s (± 1.83%)}	_{3.36s (± 0.86%)}	_~	_3.30s	_3.38s	_{p=0.106 n=6}
_{Bind Time}	_{1.32s (± 4.98%)}	_{1.30s (± 1.35%)}	_~	_1.29s	_1.34s	_{p=0.236 n=6}
_{Check Time}	_{18.20s (± 0.33%)}	_{18.04s (± 0.33%)}	_{-0.16s (- 0.89%)}	_17.95s	_18.11s	_{p=0.008 n=6}
_{Emit Time}	_{1.36s (± 1.54%)}	_{1.34s (± 1.02%)}	_~	_1.33s	_1.36s	_{p=0.192 n=6}
_{Total Time}	_{24.18s (± 0.36%)}	_{24.04s (± 0.30%)}	_{-0.14s (- 0.58%)}	_23.92s	_24.11s	_{p=0.030 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,899,135k (± 0.00%)}	_{2,900,199k (± 0.00%)}	_{+1,064k (+ 0.04%)}	_2,900,069k	_2,900,243k	_{p=0.005 n=6}
_{Parse Time}	_{12.94s (± 0.24%)}	_{12.93s (± 0.30%)}	_~	_12.89s	_13.00s	_{p=0.467 n=6}
_{Bind Time}	_{4.16s (± 0.33%)}	_{4.11s (± 0.33%)}	_{-0.05s (- 1.20%)}	_4.09s	_4.13s	_{p=0.005 n=6}
_{Check Time}	_{72.17s (± 0.32%)}	_{71.38s (± 0.17%)}	_{-0.79s (- 1.10%)}	_71.15s	_71.51s	_{p=0.005 n=6}
_{Emit Time}	_{19.34s (± 0.15%)}	_{19.31s (± 0.47%)}	_~	_19.16s	_19.43s	_{p=0.257 n=6}
_{Total Time}	_{108.60s (± 0.22%)}	_{107.72s (± 0.19%)}	_{-0.88s (- 0.81%)}	_107.34s	_107.98s	_{p=0.005 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,905k (± 0.03%)}	_{409,171k (± 0.03%)}	_{+266k (+ 0.07%)}	_409,073k	_409,388k	_{p=0.008 n=6}
_{Parse Time}	_{3.88s (± 0.28%)}	_{3.88s (± 0.42%)}	_~	_3.86s	_3.90s	_{p=0.498 n=6}
_{Bind Time}	_{1.68s (± 0.97%)}	_{1.67s (± 0.72%)}	_~	_1.66s	_1.69s	_{p=0.288 n=6}
_{Check Time}	_{16.82s (± 0.27%)}	_{16.77s (± 0.26%)}	_~	_16.73s	_16.85s	_{p=0.065 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.39s (± 0.24%)}	_{22.33s (± 0.20%)}	_{-0.07s (- 0.31%)}	_22.26s	_22.40s	_{p=0.037 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,511k (± 0.02%)}	_{514,638k (± 0.04%)}	_{+1,127k (+ 0.22%)}	_514,470k	_514,921k	_{p=0.005 n=6}
_{Parse Time}	_{3.96s (± 0.49%)}	_{3.98s (± 0.25%)}	_~	_3.97s	_3.99s	_{p=0.096 n=6}
_{Bind Time}	_{1.88s (± 1.20%)}	_{1.88s (± 1.05%)}	_~	_1.86s	_1.91s	_{p=0.806 n=6}
_{Check Time}	_{3.45s (± 0.54%)}	_{3.44s (± 0.89%)}	_~	_3.39s	_3.47s	_{p=0.935 n=6}
_{Emit Time}	_{0.08s (± 6.44%)}	_{0.08s (± 6.19%)}	_~	_0.08s	_0.09s	_{p=0.640 n=6}
_{Total Time}	_{9.38s (± 0.42%)}	_{9.39s (± 0.35%)}	_~	_9.35s	_9.44s	_{p=0.521 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-04-02T14:45:55Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,677k (± 0.01%)}	_{295,946k (± 0.01%)}	_{+269k (+ 0.09%)}	_295,918k	_295,990k	_{p=0.005 n=6}
_{Parse Time}	_{2.65s (± 0.65%)}	_{2.66s (± 0.15%)}	_~	_2.66s	_2.67s	_{p=0.209 n=6}
_{Bind Time}	_{0.84s (± 1.23%)}	_{0.82s (± 1.25%)}	_~	_0.81s	_0.84s	_{p=0.054 n=6}
_{Check Time}	_{8.26s (± 0.22%)}	_{8.21s (± 0.45%)}	_{-0.05s (- 0.63%)}	_8.15s	_8.25s	_{p=0.023 n=6}
_{Emit Time}	_{7.03s (± 0.25%)}	_{7.04s (± 0.29%)}	_~	_7.00s	_7.06s	_{p=0.871 n=6}
_{Total Time}	_{18.78s (± 0.19%)}	_{18.72s (± 0.30%)}	_~	_18.63s	_18.78s	_{p=0.064 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,281k (± 0.95%)}	_{192,670k (± 0.75%)}	_~	_192,044k	_195,625k	_{p=0.575 n=6}
_{Parse Time}	_{1.36s (± 1.00%)}	_{1.36s (± 1.45%)}	_~	_1.33s	_1.39s	_{p=0.560 n=6}
_{Bind Time}	_{0.73s (± 0.56%)}	_{0.72s (± 0.71%)}	_~	_0.72s	_0.73s	_{p=0.112 n=6}
_{Check Time}	_{9.54s (± 0.46%)}	_{9.47s (± 0.49%)}	_~	_9.41s	_9.53s	_{p=0.053 n=6}
_{Emit Time}	_{2.63s (± 0.37%)}	_{2.63s (± 0.74%)}	_~	_2.60s	_2.65s	_{p=0.869 n=6}
_{Total Time}	_{14.25s (± 0.26%)}	_{14.19s (± 0.36%)}	_~	_14.13s	_14.27s	_{p=0.065 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,424k (± 0.01%)}	_{347,830k (± 0.00%)}	_{+406k (+ 0.12%)}	_347,811k	_347,844k	_{p=0.005 n=6}
_{Parse Time}	_{2.99s (± 1.51%)}	_{2.98s (± 0.75%)}	_~	_2.94s	_3.00s	_{p=0.747 n=6}
_{Bind Time}	_{1.11s (± 0.74%)}	_{1.08s (± 0.50%)}	_{-0.02s (- 1.96%)}	_1.08s	_1.09s	_{p=0.004 n=6}
_{Check Time}	_{8.30s (± 0.12%)}	_{8.19s (± 0.24%)}	_{-0.11s (- 1.27%)}	_8.17s	_8.22s	_{p=0.004 n=6}
_{Emit Time}	_{4.84s (± 0.25%)}	_{4.85s (± 0.34%)}	_~	_4.82s	_4.87s	_{p=0.283 n=6}
_{Total Time}	_{17.24s (± 0.32%)}	_{17.11s (± 0.18%)}	_{-0.13s (- 0.73%)}	_17.07s	_17.16s	_{p=0.005 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,774k (± 0.01%)}	_{303,103k (± 0.01%)}	_{+329k (+ 0.11%)}	_303,067k	_303,156k	_{p=0.005 n=6}
_{Parse Time}	_{2.39s (± 1.05%)}	_{2.41s (± 1.41%)}	_~	_2.37s	_2.46s	_{p=0.570 n=6}
_{Bind Time}	_{1.19s (± 0.63%)}	_{1.18s (± 0.64%)}	_~	_1.17s	_1.19s	_{p=0.195 n=6}
_{Check Time}	_{7.54s (± 0.37%)}	_{7.49s (± 0.29%)}	_{-0.06s (- 0.77%)}	_7.45s	_7.51s	_{p=0.006 n=6}
_{Emit Time}	_{4.27s (± 0.41%)}	_{4.27s (± 0.69%)}	_~	_4.23s	_4.31s	_{p=1.000 n=6}
_{Total Time}	_{15.39s (± 0.34%)}	_{15.34s (± 0.08%)}	_~	_15.32s	_15.35s	_{p=0.056 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,067k (± 0.01%)}	_{510,581k (± 0.00%)}	_{+515k (+ 0.10%)}	_510,548k	_510,604k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.24%)}	_{2.66s (± 0.44%)}	_~	_2.65s	_2.68s	_{p=1.000 n=6}
_{Bind Time}	_{0.99s (± 1.18%)}	_{0.98s (± 0.77%)}	_~	_0.97s	_0.99s	_{p=0.097 n=6}
_{Check Time}	_{17.31s (± 0.31%)}	_{17.30s (± 0.35%)}	_~	_17.20s	_17.37s	_{p=0.683 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.97s (± 0.30%)}	_{20.95s (± 0.27%)}	_~	_20.86s	_21.01s	_{p=0.422 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,745,006k (± 0.00%)}	_{1,746,029k (± 0.00%)}	_{+1,023k (+ 0.06%)}	_1,745,939k	_1,746,108k	_{p=0.005 n=6}
_{Parse Time}	_{6.60s (± 0.42%)}	_{6.63s (± 0.76%)}	_~	_6.58s	_6.69s	_{p=0.868 n=6}
_{Bind Time}	_{2.38s (± 0.83%)}	_{2.35s (± 0.79%)}	_{-0.03s (- 1.19%)}	_2.33s	_2.38s	_{p=0.032 n=6}
_{Check Time}	_{56.52s (± 0.29%)}	_{56.58s (± 0.25%)}	_~	_56.41s	_56.78s	_{p=0.378 n=6}
_{Emit Time}	_{0.13s (± 0.00%)}	_{0.13s (± 3.10%)}	_~	_0.13s	_0.14s	_{p=0.405 n=6}
_{Total Time}	_{65.63s (± 0.23%)}	_{65.69s (± 0.24%)}	_~	_65.47s	_65.86s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,400,539k (± 0.01%)}	_{2,405,186k (± 0.03%)}	_{+4,647k (+ 0.19%)}	_2,404,040k	_2,406,023k	_{p=0.005 n=6}
_{Parse Time}	_{6.04s (± 1.16%)}	_{6.09s (± 1.68%)}	_~	_6.01s	_6.28s	_{p=0.470 n=6}
_{Bind Time}	_{2.25s (± 1.17%)}	_{2.26s (± 1.99%)}	_~	_2.21s	_2.34s	_{p=1.000 n=6}
_{Check Time}	_{39.93s (± 0.44%)}	_{39.54s (± 0.44%)}	_{-0.39s (- 0.99%)}	_39.35s	_39.81s	_{p=0.008 n=6}
_{Emit Time}	_{3.15s (± 1.81%)}	_{3.09s (± 3.85%)}	_~	_2.95s	_3.24s	_{p=0.575 n=6}
_{Total Time}	_{51.40s (± 0.27%)}	_{51.00s (± 0.70%)}	_~	_50.71s	_51.62s	_{p=0.093 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,180k (± 0.01%)}	_{416,246k (± 0.01%)}	_{+67k (+ 0.02%)}	_416,209k	_416,277k	_{p=0.045 n=6}
_{Parse Time}	_{3.33s (± 1.24%)}	_{3.32s (± 0.25%)}	_~	_3.31s	_3.33s	_{p=0.870 n=6}
_{Bind Time}	_{1.29s (± 0.49%)}	_{1.31s (± 1.32%)}	_~	_1.29s	_1.33s	_{p=0.059 n=6}
_{Check Time}	_{18.20s (± 0.14%)}	_{17.95s (± 0.40%)}	_{-0.25s (- 1.36%)}	_17.85s	_18.04s	_{p=0.005 n=6}
_{Emit Time}	_{1.34s (± 1.12%)}	_{1.35s (± 0.98%)}	_~	_1.33s	_1.37s	_{p=0.677 n=6}
_{Total Time}	_{24.16s (± 0.20%)}	_{23.93s (± 0.33%)}	_{-0.23s (- 0.97%)}	_23.81s	_24.03s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,899,134k (± 0.00%)}	_{2,900,156k (± 0.00%)}	_{+1,021k (+ 0.04%)}	_2,900,121k	_2,900,226k	_{p=0.005 n=6}
_{Parse Time}	_{12.97s (± 0.52%)}	_{12.93s (± 0.22%)}	_~	_12.88s	_12.96s	_{p=0.470 n=6}
_{Bind Time}	_{4.14s (± 0.25%)}	_{4.13s (± 0.48%)}	_~	_4.11s	_4.16s	_{p=0.119 n=6}
_{Check Time}	_{72.20s (± 0.31%)}	_{71.56s (± 0.60%)}	_{-0.64s (- 0.89%)}	_70.95s	_72.05s	_{p=0.013 n=6}
_{Emit Time}	_{20.03s (± 7.67%)}	_{19.35s (± 0.47%)}	_~	_19.24s	_19.44s	_{p=0.521 n=6}
_{Total Time}	_{109.34s (± 1.55%)}	_{107.96s (± 0.42%)}	_{-1.38s (- 1.26%)}	_107.42s	_108.44s	_{p=0.031 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,876k (± 0.01%)}	_{409,180k (± 0.03%)}	_{+304k (+ 0.07%)}	_409,054k	_409,375k	_{p=0.005 n=6}
_{Parse Time}	_{3.88s (± 0.78%)}	_{3.88s (± 0.46%)}	_~	_3.85s	_3.90s	_{p=0.517 n=6}
_{Bind Time}	_{1.69s (± 0.48%)}	_{1.67s (± 1.12%)}	_{-0.03s (- 1.57%)}	_1.63s	_1.68s	_{p=0.007 n=6}
_{Check Time}	_{16.82s (± 0.29%)}	_{16.75s (± 0.20%)}	_{-0.08s (- 0.45%)}	_16.70s	_16.80s	_{p=0.037 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.39s (± 0.07%)}	_{22.30s (± 0.15%)}	_{-0.10s (- 0.43%)}	_22.25s	_22.33s	_{p=0.005 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,544k (± 0.02%)}	_{514,576k (± 0.02%)}	_{+1,032k (+ 0.20%)}	_514,475k	_514,687k	_{p=0.005 n=6}
_{Parse Time}	_{4.91s (± 0.53%)}	_{4.91s (± 0.56%)}	_~	_4.87s	_4.95s	_{p=0.809 n=6}
_{Bind Time}	_{2.32s (± 0.77%)}	_{2.30s (± 0.93%)}	_~	_2.27s	_2.32s	_{p=0.167 n=6}
_{Check Time}	_{4.29s (± 0.82%)}	_{4.31s (± 0.27%)}	_~	_4.30s	_4.33s	_{p=0.935 n=6}
_{Emit Time}	_{0.11s (± 0.00%)}	_{0.11s (± 0.00%)}	_~	_0.11s	_0.11s	_{p=1.000 n=6}
_{Total Time}	_{11.63s (± 0.54%)}	_{11.62s (± 0.29%)}	_~	_11.58s	_11.67s	_{p=0.377 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

ahejlsberg · 2024-04-02T14:52:49Z

Generally positive impact on performance with check time savings of up to 1.5%. Note that this is an API breaking change due to the more uniform layout of flow nodes.

typescript-bot · 2024-04-02T15:53:01Z

@ahejlsberg Here are the results of running the top 400 repos comparing main and refs/pull/57977/merge:

Everything looks good!

jakebailey · 2024-04-02T15:59:54Z

Note that this is an API breaking change due to the more uniform layout of flow nodes.

To be honest, I'm not sure why any of FlowNode or FlowFlags are public; they are not referenced by anything but themselves. Makes me wonder if we should just be removing these so we can make more changes at will.

But, the API break will probably break the playground's flow node viewer and ts-ast-viewer.com's, but we can probably update both. Realistically the former should have been calling into ts.Debug anyway, and the latter pins specific TS versions, I think.

jakebailey · 2024-04-02T16:30:36Z

src/compiler/types.ts

-    id?: number; // Node id used by flow type cache in checker
+    id: number; // Node id used by flow type cache in checker
+    node: unknown; // Node or other data
+    antecedent: FlowNode | FlowNode[] | undefined;


I'm kind of surprised that this turned out okay; I would have thought these two types would have different shapes, but I guess they're both pointers...

They're both heap objects so should get the same hidden class.

jakebailey · 2024-04-02T17:27:23Z

I opened #58036 which would remove the flow types from the public API, and make this change "non breaking" in a way 😄

ahejlsberg · 2024-04-02T17:31:43Z

@jakebailey Maybe we just fold the @internal change into this PR? So we have all the breaks in one place.

jakebailey · 2024-04-02T17:35:04Z

I figured it may be better not to, just to make it clear that we intentionally removed them, but I'm not against it if we're good with removing them.

If #58036 is merged first, then your PR doesn't have any breaks (no baseline changes at all).

ahejlsberg · 2024-04-03T00:50:21Z

If #58036 is merged first, then your PR doesn't have any breaks (no baseline changes at all).

Fine by me.

# Conflicts: # src/compiler/checker.ts

jakebailey · 2024-04-03T01:29:12Z

Done ☺️

src/compiler/binder.ts

# Conflicts: # src/compiler/types.ts # tests/baselines/reference/api/typescript.d.ts

# Conflicts: # src/compiler/binder.ts

ahejlsberg added 2 commits March 27, 2024 18:03

All flow nodes created by single createFlowNode function

db40d91

Accept new API baselines

2deadcb

typescript-bot assigned ahejlsberg Mar 28, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 28, 2024

Use constructor function

773c98b

ahejlsberg added 2 commits March 28, 2024 09:25

Exclude optional 'id' property

7e4fee7

Accept new API baselines

87c46f0

Cache incomplete types

654df90

ahejlsberg added 3 commits March 31, 2024 15:02

Same shape for all nodes except FlowSwitchClause

efe8335

Update imports

5109c05

Accept new baselines

d0d2e3d

ahejlsberg requested review from DanielRosenwasser and RyanCavanaugh April 2, 2024 14:53

jakebailey mentioned this pull request Apr 2, 2024

Remove FlowNodes and FlowFlags from public API #58036

Merged

jakebailey reviewed Apr 2, 2024

View reviewed changes

DanielRosenwasser mentioned this pull request Apr 2, 2024

Design Meeting Notes, 4/2/2024 #58043

Closed

Merge branch 'main' into monomorphicFlowNodes

f3dd024

# Conflicts: # src/compiler/checker.ts

jakebailey reviewed Apr 3, 2024

View reviewed changes

src/compiler/binder.ts Show resolved Hide resolved

ahejlsberg added 2 commits April 4, 2024 16:16

Make createFlowNode internal

423f96d

Merge branch 'main' into monomorphicFlowNodes

8c289a5

# Conflicts: # src/compiler/types.ts # tests/baselines/reference/api/typescript.d.ts

jakebailey approved these changes Apr 4, 2024

View reviewed changes

Merge branch 'main' into monomorphicFlowNodes

2d58401

# Conflicts: # src/compiler/binder.ts

ahejlsberg merged commit 39daa13 into main Apr 4, 2024

ahejlsberg deleted the monomorphicFlowNodes branch April 4, 2024 23:53

DanielRosenwasser mentioned this pull request Apr 5, 2024

Design Meeting Notes, 4/5/2024 #58096

Closed

jfet97 mentioned this pull request Jul 9, 2024

Handle both single and multiple antecedents in "antecedent" field dsherret/ts-ast-viewer#155

Merged

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Conversation

ahejlsberg commented Mar 28, 2024

Uh oh!

typescript-bot commented Mar 28, 2024

Uh oh!

ahejlsberg commented Mar 28, 2024

Uh oh!

typescript-bot commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 28, 2024

Uh oh!

typescript-bot commented Mar 28, 2024

Uh oh!

typescript-bot commented Mar 28, 2024

tsc

Uh oh!

typescript-bot commented Mar 28, 2024

Uh oh!

ahejlsberg commented Mar 28, 2024

Uh oh!

typescript-bot commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 28, 2024

tsc

Uh oh!

ahejlsberg commented Mar 28, 2024

Uh oh!

typescript-bot commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahejlsberg commented Mar 28, 2024

Uh oh!

typescript-bot commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 28, 2024

tsc

Uh oh!

typescript-bot commented Mar 28, 2024

tsc

Uh oh!

ahejlsberg commented Mar 31, 2024

Uh oh!

typescript-bot commented Mar 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahejlsberg commented Apr 2, 2024

Uh oh!

typescript-bot commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 2, 2024

Uh oh!

typescript-bot commented Apr 2, 2024

Uh oh!

typescript-bot commented Apr 2, 2024

tsc

Uh oh!

typescript-bot commented Apr 2, 2024

tsc

Uh oh!

ahejlsberg commented Apr 2, 2024

Uh oh!

typescript-bot commented Apr 2, 2024

Uh oh!

jakebailey commented Apr 2, 2024

Uh oh!

jakebailey Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

ahejlsberg Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Apr 2, 2024

Uh oh!

ahejlsberg commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 28, 2024 •

edited

Loading

typescript-bot commented Mar 28, 2024 •

edited

Loading

typescript-bot commented Mar 28, 2024 •

edited

Loading

typescript-bot commented Mar 28, 2024 •

edited

Loading

typescript-bot commented Mar 31, 2024 •

edited

Loading

typescript-bot commented Apr 2, 2024 •

edited

Loading

ahejlsberg commented Apr 2, 2024 •

edited

Loading