Skip to content

Add mousedown,contextmenu events to terminal find#194817

Merged
Tyriar merged 3 commits intomicrosoft:mainfrom
tisilent:fix-terminal-find-rightclick
Nov 10, 2023
Merged

Add mousedown,contextmenu events to terminal find#194817
Tyriar merged 3 commits intomicrosoft:mainfrom
tisilent:fix-terminal-find-rightclick

Conversation

@tisilent
Copy link
Contributor

@tisilent tisilent commented Oct 4, 2023

fix #194814.

Reason:

this._register(dom.addDisposableListener(terminalContainer, 'mousedown', async (event: MouseEvent) => {
const terminal = this._terminalGroupService.activeInstance;

this._register(dom.addDisposableListener(this._innerDomNode, 'click', (event) => {
event.stopPropagation();
}));

Try not to affect webview.
I not sure how to use the workbench context menu 😅.

Edit:
I have thought too much, but in fact the workbench context menu has been TerminalTabbedView stoped and cannot be enjoyed. 😄

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👏

@Tyriar Tyriar added this to the November 2023 milestone Nov 10, 2023
@Tyriar Tyriar enabled auto-merge November 10, 2023 16:40
@Tyriar Tyriar merged commit 0bd4ad9 into microsoft:main Nov 10, 2023
@tisilent tisilent deleted the fix-terminal-find-rightclick branch November 10, 2023 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal find: right click execution error

5 participants