BUG: pretty print all Mappings, not just dicts#57915
Merged
mroeschke merged 1 commit intopandas-dev:mainfrom Mar 20, 2024
Merged
BUG: pretty print all Mappings, not just dicts#57915mroeschke merged 1 commit intopandas-dev:mainfrom
mroeschke merged 1 commit intopandas-dev:mainfrom
Conversation
mroeschke
reviewed
Mar 19, 2024
Member
mroeschke
left a comment
There was a problem hiding this comment.
I think this would be OK. Could you come up with a test?
3e9d00b to
c5e8968
Compare
Contributor
Author
|
that was a pretty nice experience setting up a dev environment locally, pass along my compliments to the rest of the pandas maintainers @mroeschke ! |
mroeschke
reviewed
Mar 19, 2024
mroeschke
reviewed
Mar 19, 2024
Member
mroeschke
left a comment
There was a problem hiding this comment.
Could you also add a whatsnew note in v3.0.0.rst?
This was discovered in ibis-project/ibis#8693
c5e8968 to
777740f
Compare
mroeschke
approved these changes
Mar 19, 2024
Member
|
Thanks @NickCrews |
3 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
This was discovered in ibis-project/ibis#8693
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discovered in ibis-project/ibis#8687
Due to a strict
isinstance(x, dict)check, custom mapping types would instead get treated as mere iterables, so only the keys would get printed as a tuple:doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.