fix-up R parser bug in get_source_expressions#1056
Merged
MichaelChirico merged 2 commits intomasterfrom Apr 10, 2022
Merged
Conversation
AshesITR
previously approved these changes
Apr 9, 2022
Collaborator
Author
|
Adding a NEWS bullet and tests... |
AshesITR
approved these changes
Apr 10, 2022
Collaborator
|
Will this fix the xml as well? I suppose no, just wanted to confirm. |
Collaborator
Author
|
Yes it will, because Here we pass the data.frame: Line 99 in 49fd346 Here https://github.com/r-lib/xmlparsedata/blob/ee6a15f0b9162e2d215635d9771dc5c09d3eacbf/R/package.R#L65 (this is why the other touch-ups, i.e. for tabs and equals signs, are also reflected on the XML tree we get back from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #1032 because in principle it could affect the logic whenever
STR_CONSTis involved (especially, it's probably needed as part of #1034)