Skip to content

New failure in 'adaptalint' #1997

@MichaelChirico

Description

@MichaelChirico

Haven't had time to explore yet, but there's a new failure in the 'adaptalint' test suite [v3.0.2 vs current HEAD]:

── Error (test-basics.R:29:3): extract works in simple case ────────────────────
<tibble_error_column_names_cannot_be_empty/tibble_error/rlang_error/error/condition>
Error in `as_tibble(.)`: Columns 1, 2, 3, 4, 5, and 18 more must be named.
Use `.name_repair` to specify repair.
Caused by error in `repaired_names()`:
! Names can't be empty.
✖ Empty names found at locations 1, 2, 3, 4, 5, etc.

It's a simple test of adaptalint::extract_style(); that function looks like:

filename %>%
  lint() %>%
  as_tibble() %>%
  mutate(total_lints = n()) %>%
  group_by(.data$linter) %>%
  summarise(count = n(),
            total_lints = mean(.data$total_lints)
  ) %>%
  mutate(adjusted = .data$count/.data$total_lints)

The first thing that comes to mind is the new S3 dispatch... we might need to add an as_tibble.lints method, perhaps?

Metadata

Metadata

Assignees

No one assigned

    Labels

    regressioncode that used to work, but now doesn't

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions