Normalize output to Forward slash#2613
Normalize output to Forward slash#2613IndrajeetPatil merged 10 commits intor-lib:mainfrom olivroy:forward-slash
Conversation
|
Thanks! makes sense to me. admittedly, it feels weird to override the platform settings and force '/', but I don't know of any OS in current use that doesn't understand '/' so it's kinda moot. I think more importantly, this PR suffers from threat of future regression -- there's nothing stopping us from using file.path()/normalizePath() the "old" way going forward. Could you file a follow-up FR about a linter for this purpose? we can hash out design details there. It needn't impede this PR from being merged but needs to be recorded before slipping through the cracks. |
|
Thanks for looking into it! I did this quickly to see if it could work (and if there was interest). I will look into removing changes, and see which ones are actually necessary. If there are <10, this would be less scary, and it could be documented where this is needed and not? |
|
Some tests feel redundant now (they are just testing the equivalency of paths). The only problem is that local_tempfile_f <- function(...) {
file <- withr::local_tempfile()
normalize_path(file)
} |
|
The approach of just using |
Minor annoyance, but thought I'd share the PR in case there is interest
it is just to fix a minor inconsistency between Unix and Windows.
This basically just changes that and makes sure that the names of the linted object are the same on both platforms with forward slash