Skip to content

Fix/centroids should return NAs where NA in dyadID or fusionID#114

Merged
robitalec merged 4 commits intomainfrom
fix/na-centroid
Sep 10, 2025
Merged

Fix/centroids should return NAs where NA in dyadID or fusionID#114
robitalec merged 4 commits intomainfrom
fix/na-centroid

Conversation

@robitalec
Copy link
Copy Markdown
Member

@robitalec robitalec commented Sep 9, 2025 •
edited
Loading

Bug:

       timegroup    ID1    ID2 distance dyadID fusionID centroid_X centroid_Y
           <int> <char> <char>    <num> <char>    <int>      <num>      <num>
    1:         1      A   <NA>       NA   <NA>       NA   715851.4    5505340
    2:         1      B      G 5.782904    B-G        1   699637.9    5509637
    3:         1      C   <NA>       NA   <NA>       NA   710205.4    5505888
    4:         1      D   <NA>       NA   <NA>       NA   700875.0    5490954
    5:         1      E   <NA>       NA   <NA>       NA   701671.9    5504286

@robitalec robitalec self-assigned this Sep 9, 2025
@robitalec robitalec added status: completed and removed status: confirmed bug is reproducible labels Sep 9, 2025
@robitalec
Copy link
Copy Markdown
Member Author

robitalec commented Sep 10, 2025

Fix:

      timegroup    ID1    ID2 distance dyadID centroid_X centroid_Y
          <int> <char> <char>    <num> <char>      <num>      <num>
   1:         1      A   <NA>       NA   <NA>   715851.4    5505340
   2:         1      C   <NA>       NA   <NA>   710205.4    5505888
   3:         1      D   <NA>       NA   <NA>   700875.0    5490954
   4:         1      F   <NA>       NA   <NA>   705583.0    5513813
   5:         1      I   <NA>       NA   <NA>   711042.0    5506384

@robitalec robitalec merged commit 8b68433 into main Sep 10, 2025
6 checks passed
@robitalec robitalec deleted the fix/na-centroid branch September 10, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@robitalec robitalec

Labels

priority: high status: completed type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@robitalec