Skip to content

Windows fix - #213

Merged
rosell-dk merged 6 commits into
rosell-dk:masterfrom
lwxbr:windows-fix
Mar 20, 2019
Merged

Windows fix#213
rosell-dk merged 6 commits into
rosell-dk:masterfrom
lwxbr:windows-fix

Conversation

@lwxbr

@lwxbr lwxbr commented Mar 20, 2019

Copy link
Copy Markdown
Contributor

Some modifications to run the plugin in XAMPP 7.3.1 in Windows 10.

@lwxbr lwxbr mentioned this pull request Mar 20, 2019
@lwxbr

lwxbr commented Mar 20, 2019

Copy link
Copy Markdown
Contributor Author

Note: to work perfectly, the fix of GD Converter must be considered:
rosell-dk/webp-convert#113

@rosell-dk
rosell-dk merged commit c429426 into rosell-dk:master Mar 20, 2019
@rosell-dk rosell-dk added this to the 0.13: Bulk Convert milestone Mar 20, 2019
@rosell-dk

Copy link
Copy Markdown
Owner

Thanks a lot!

@rosell-dk

Copy link
Copy Markdown
Owner

I predict that webp-realizer.php isn't working on Windows? - It is the ability to generate a webp when the webp is visited. It now calls ConvertHelperIndependent::findSourceSeparate to find source. And that currently uses the following code to decide if $destination is inside the "doc-root" folder of the cache dir:

if (strpos($destination, $imageRoot . '/doc-root/') === 0) {
   ...
}

We cannot use realpath in this case, because $destination does not exist yet.

@lwxbr

lwxbr commented Mar 21, 2019

Copy link
Copy Markdown
Contributor Author

Yes, you are right, you can't use realpath to normalize directory paths because it only works with real paths (paths that exist in current filesystem) as the name of function says, but you can create a function that does that or get a function from a composer module that handle this, it would be interesting look for some module that works both for Linux, Windows and related systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants