Skip to content

[cfg_match] Document the use of expressions.#135625

Merged
bors merged 1 commit into
rust-lang:masterfrom
c410-f3r:cfg-match-foo-bar-baz
Jan 29, 2025
Merged

[cfg_match] Document the use of expressions.#135625
bors merged 1 commit into
rust-lang:masterfrom
c410-f3r:cfg-match-foo-bar-baz

Conversation

@c410-f3r

@c410-f3r c410-f3r commented Jan 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

cc #115585

Adds documentation to this new feature introduced in #133720.

@rustbot

rustbot commented Jan 17, 2025

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 17, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ehuss

ehuss commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

Can you remove all of the submodule updates?

@c410-f3r c410-f3r force-pushed the cfg-match-foo-bar-baz branch from 90608ee to 5844eac Compare January 17, 2025 15:30
@c410-f3r

c410-f3r commented Jan 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

r? T-libs

@rustbot rustbot assigned tgross35 and jhpratt and unassigned joboet and tgross35 Jan 21, 2025
tgross35
tgross35 reviewed Jan 21, 2025
View reviewed changes
Comment thread library/core/src/macros/mod.rs Outdated
/// }
/// ```
///
/// If desired, it is possible to return expressions through the use of surrounding braces.

@tgross35 tgross35 Jan 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// If desired, it is possible to return expressions through the use of surrounding braces.
/// If desired, it is possible to return expressions through the use of surrounding braces:

Nit, colon to introduce an example

@tgross35

tgross35 commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

One nit and squash please, then r=me

@c410-f3r c410-f3r force-pushed the cfg-match-foo-bar-baz branch from 5844eac to 587b9c6 Compare January 21, 2025 11:45
@jhpratt

jhpratt commented Jan 21, 2025

Copy link
Copy Markdown
Member

@bors r=tgross35,jhpratt rollup

@bors

bors commented Jan 21, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 587b9c6 has been approved by tgross35,jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2025
@jieyouxu jieyouxu mentioned this pull request Jan 21, 2025
Closed
@jieyouxu jieyouxu mentioned this pull request Jan 21, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 21, 2025
Closed
@matthiaskrgr

matthiaskrgr commented Jan 21, 2025

Copy link
Copy Markdown
Member

@bors r-
#135835 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 21, 2025
@rustbot rustbot assigned tgross35 and Noratrieb and unassigned jhpratt, joboet and tgross35 Jan 28, 2025
@tgross35

tgross35 commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

@bors r=tgross35,jhpratt

Do we know why it choked on the comma?

The macro does not support trailing commas at the current time.

Why was this not a problem during PR CI though?

@bors

bors commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 7d9fe91 has been approved by tgross35,jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2025
@Zalathar Zalathar mentioned this pull request Jan 29, 2025
Closed
@fmease fmease mentioned this pull request Jan 29, 2025
Merged
@bors bors merged commit 53f343f into rust-lang:master Jan 29, 2025
@rustbot rustbot added this to the 1.86.0 milestone Jan 29, 2025
@madsmtm madsmtm mentioned this pull request Feb 17, 2025
Closed
5 tasks
@jieyouxu jieyouxu added the F-cfg_select `#![feature(cfg_select)]` label Aug 14, 2025
@folkertdev folkertdev mentioned this pull request Dec 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 left review comments

Assignees

@Noratrieb Noratrieb

Labels

F-cfg_select `#![feature(cfg_select)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.