Skip to content

Commit 169b2a3

Browse files
committed
Java tests: Don't attempt to "recover from sauce error" if it's just an assumption exception that contains "sauce" word in the message
1 parent 835190d commit 169b2a3

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

java/client/test/org/openqa/selenium/testing/JUnit4TestBase.java

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
import com.google.common.base.Throwables;
2626

27+
import org.junit.AssumptionViolatedException;
2728
import org.junit.Before;
2829
import org.junit.Rule;
2930
import org.junit.rules.RuleChain;
@@ -112,9 +113,7 @@ protected void starting(Description description) {
112113
removeDriver();
113114
}
114115
try {
115-
driver = actuallyCreateDriver();
116-
wait = new WebDriverWait(driver, 30);
117-
shortWait = new WebDriverWait(driver, 5);
116+
createDriver();
118117
} catch (Exception e) {
119118
throw new RuntimeException("Exception creating driver", e);
120119
}
@@ -159,11 +158,11 @@ public void evaluate() throws Throwable {
159158
}
160159

161160
private void dealWithSauceFailureIfNecessary(Throwable t) {
162-
if (t.getMessage() != null
161+
if (!(t instanceof AssumptionViolatedException) && t.getMessage() != null
163162
&& (t.getMessage().contains("sauce") || t.getMessage().contains("Sauce"))) {
164163
removeDriver();
165164
try {
166-
actuallyCreateDriver();
165+
createDriver();
167166
} catch (Exception e) {
168167
throw new RuntimeException("Exception creating driver, after Sauce-detected exception", e);
169168
}
@@ -267,6 +266,12 @@ public WebDriver getWrappedDriver() {
267266
return storedDriver.get();
268267
}
269268

269+
private void createDriver() {
270+
driver = actuallyCreateDriver();
271+
wait = new WebDriverWait(driver, 30);
272+
shortWait = new WebDriverWait(driver, 5);
273+
}
274+
270275
public static WebDriver actuallyCreateDriver() {
271276
WebDriver driver = storedDriver.get();
272277

0 commit comments

Comments
 (0)