Skip to content

Commit 1dbcbc2

Browse files
committed
Fixing case of requiredCapabilities == null
1 parent 34e41e6 commit 1dbcbc2

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

java/client/src/org/openqa/selenium/Capabilities.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,9 @@ default boolean is(String capabilityName) {
9595
default Capabilities merge(Capabilities other) {
9696
HashMap<String, Object> map = new HashMap<>();
9797
map.putAll(asMap());
98-
map.putAll(other.asMap());
98+
if (other != null) {
99+
map.putAll(other.asMap());
100+
}
99101
return new ImmutableCapabilities(map);
100102
}
101103
}

java/client/src/org/openqa/selenium/remote/DesiredCapabilities.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,9 @@ public Object getCapability(String capabilityName) {
139139
public DesiredCapabilities merge(Capabilities extraCapabilities) {
140140
if (extraCapabilities != null) {
141141
capabilities.putAll(extraCapabilities.asMap());
142-
}
143-
if (extraCapabilities.getCapability(UNEXPECTED_ALERT_BEHAVIOUR) != null) {
144-
capabilities.put(UNHANDLED_PROMPT_BEHAVIOUR, extraCapabilities.getCapability(UNEXPECTED_ALERT_BEHAVIOUR));
142+
if (extraCapabilities.getCapability(UNEXPECTED_ALERT_BEHAVIOUR) != null) {
143+
capabilities.put(UNHANDLED_PROMPT_BEHAVIOUR, extraCapabilities.getCapability(UNEXPECTED_ALERT_BEHAVIOUR));
144+
}
145145
}
146146
return this;
147147
}

0 commit comments

Comments
 (0)