Skip to content

Commit 5347266

Browse files
[Build] Correct dependency management for code generator
1 parent 9e73ad7 commit 5347266

2 files changed

Lines changed: 16 additions & 5 deletions

File tree

WORKSPACE

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,19 @@ load("@rules_python//python:repositories.bzl", "py_repositories")
108108
py_repositories()
109109

110110
# This one is only needed if you're using the packaging rules.
111-
load("@rules_python//python:pip.bzl", "pip_repositories", "pip_import")
111+
load("@rules_python//python:pip.bzl", "pip_import", "pip_repositories")
112+
112113
pip_import(
113114
name = "dev_requirements",
114-
requirements="//py:requirements.txt",
115+
requirements = "//py:requirements.txt",
115116
)
117+
116118
load("@dev_requirements//:requirements.bzl", "pip_install")
117-
pip_install()
118119

119120
pip_repositories()
120121

122+
pip_install()
123+
121124
http_archive(
122125
name = "rules_pkg",
123126
sha256 = "aeca78988341a2ee1ba097641056d168320ecc51372ef7ff8e64b139516a4937",

py/BUILD.bazel

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
load("@rules_python//python:defs.bzl", "py_binary", "py_library", "py_test")
22
load("@rules_python//experimental/python:wheel.bzl", "py_package", "py_wheel")
3+
load("@dev_requirements//:requirements.bzl", "requirement")
34
load("//py:defs.bzl", "py_test_suite", "pytest_test")
45
load("//:copy_file.bzl", "copy_file")
56

@@ -116,16 +117,23 @@ py_library(
116117
],
117118
)
118119

120+
py_binary(
121+
name = "generate",
122+
srcs = ["generate.py"],
123+
srcs_version = "PY3",
124+
deps = [requirement("inflection")],
125+
)
126+
119127
genrule(
120128
name = "create-cdp-srcs",
121129
srcs = [
122-
"generate.py",
123130
":browser_protocol",
124131
":js_protocol",
125132
],
126133
outs = ["selenium/webdriver/common/devtools"],
127-
cmd = "python3 $(location generate.py) $(location :browser_protocol) $(location :js_protocol) $@",
134+
cmd = "python3 $(location :generate) $(location :browser_protocol) $(location :js_protocol) $@",
128135
tools = [
136+
":generate",
129137
],
130138
)
131139

0 commit comments

Comments
 (0)