Skip to content

Commit 7d5913d

Browse files
committed
Support CDP v87 in Ruby
1 parent b3b7d94 commit 7d5913d

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

rb/build.desc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ ruby_library(name = "chrome",
6161

6262
ruby_library(name = "remote",
6363
srcs = [
64-
"lib/selenium/webdriver/remote/**/*.rb",
65-
"lib/selenium/webdriver/remote.rb"
64+
"lib/selenium/webdriver/remote/**/*.rb",
65+
"lib/selenium/webdriver/remote.rb"
6666
],
6767
resources = [
6868
{"//java/server/src/org/openqa/selenium/grid:selenium_server_deploy.jar": "rb/selenium_server_deploy.jar"}

rb/lib/selenium/webdriver/devtools.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class DevTools
2424
autoload :ExceptionEvent, 'selenium/webdriver/devtools/exception_event'
2525
autoload :MutationEvent, 'selenium/webdriver/devtools/mutation_event'
2626

27-
SUPPORTED_VERSIONS = [84, 85, 86].freeze
27+
SUPPORTED_VERSIONS = [84, 85, 86, 87].freeze
2828

2929
def initialize(url:, version:)
3030
@messages = []

rb/spec/unit/selenium/webdriver/support/cdp_client_generator_spec.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,23 @@ module Selenium
2323
module WebDriver
2424
module Support
2525
describe CDPClientGenerator do
26+
subject(:generator) { CDPClientGenerator.new }
27+
2628
describe '#snake_case' do
2729
it 'converts from camel case' do
28-
expect(subject.snake_case('setDataSizeLimitsForTest')).to eq('set_data_size_limits_for_test')
30+
expect(generator.snake_case('setDataSizeLimitsForTest')).to eq('set_data_size_limits_for_test')
2931
end
3032

3133
it 'converts acronyms' do
32-
expect(subject.snake_case('setExtraHTTPHeaders')).to eq('set_extra_http_headers')
34+
expect(generator.snake_case('setExtraHTTPHeaders')).to eq('set_extra_http_headers')
3335
end
3436

3537
it 'converts pluralized acronyms' do
36-
expect(subject.snake_case('setBlockedURLs')).to eq('set_blocked_urls')
38+
expect(generator.snake_case('setBlockedURLs')).to eq('set_blocked_urls')
3739
end
3840

3941
it 'makes an exception for JavaScript' do
40-
expect(subject.snake_case('forciblyPurgeJavaScriptMemory')).to eq('forcibly_purge_javascript_memory')
42+
expect(generator.snake_case('forciblyPurgeJavaScriptMemory')).to eq('forcibly_purge_javascript_memory')
4143
end
4244
end
4345
end # CDPClientGenerator

0 commit comments

Comments
 (0)