Skip to content

Commit aa7be6f

Browse files
committed
Fix failing webdriver atom test on firefox
1 parent dd48621 commit aa7be6f

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

javascript/webdriver/test/atoms/inject/dom_test.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,10 @@
152152

153153
function testGetSizeInFrame() {
154154
var elementRef = window.frames[0].document.getElementById("submitForm");
155-
var expectedHeight = goog.style.getSize(elementRef).height;
155+
// On Firefox, goog.style.getSize returns 20 instead of 19. The bounding box is 19.5 on my
156+
// machine. Rather than allow multiple values, we'll just grab the bounding rect.
157+
var rect = elementRef.getBoundingClientRect();
158+
var expectedHeight = Math.floor(rect.bottom - rect.top);
156159
var frame = webdriver.atoms.inject.frame.findFrameByIndex(0);
157160
var frameWindow = getValueFromJSONObject(frame);
158161
var element = webdriver.atoms.inject.locators.findElement(

0 commit comments

Comments
 (0)