Skip to content

Commit b1beaa0

Browse files
committed
[grid] Using random port for SessionQueueGridTest [skip ci]
1 parent ea97f91 commit b1beaa0

4 files changed

Lines changed: 4 additions & 6 deletions

File tree

java/server/src/org/openqa/selenium/grid/docker/DockerSessionFactory.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,6 @@ private void saveSessionCapabilities(Capabilities sessionRequestCapabilities, Pa
337337
} catch (IOException e) {
338338
LOG.log(Level.WARNING,
339339
"Failed to save session capabilities as metadata", e);
340-
e.printStackTrace();
341340
}
342341
}
343342

java/server/test/org/openqa/selenium/grid/node/config/NodeOptionsTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717

1818
package org.openqa.selenium.grid.node.config;
1919

20-
import com.google.common.collect.ImmutableList;
21-
import com.google.common.collect.ImmutableMap;
2220
import org.assertj.core.api.Condition;
2321
import org.junit.Before;
2422
import org.junit.Test;
@@ -56,7 +54,6 @@
5654
import static java.util.Collections.emptySet;
5755
import static java.util.Collections.singletonMap;
5856
import static org.assertj.core.api.Assertions.assertThat;
59-
import static org.assertj.core.api.Assertions.fail;
6057
import static org.junit.Assume.assumeFalse;
6158
import static org.junit.Assume.assumeTrue;
6259
import static org.mockito.Mockito.spy;

java/server/test/org/openqa/selenium/grid/router/SessionQueueGridTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
import org.openqa.selenium.grid.testing.TestSessionFactory;
6969
import org.openqa.selenium.grid.web.CombinedHandler;
7070
import org.openqa.selenium.grid.web.RoutableHttpClientFactory;
71+
import org.openqa.selenium.net.PortProber;
7172
import org.openqa.selenium.netty.server.NettyServer;
7273
import org.openqa.selenium.remote.http.HttpClient;
7374
import org.openqa.selenium.remote.http.HttpHandler;
@@ -232,7 +233,8 @@ public void stopServer() {
232233
private static Server<?> createServer(HttpHandler handler) {
233234
return new NettyServer(
234235
new BaseServerOptions(
235-
new MapConfig(ImmutableMap.of("server", ImmutableMap.of("port", 4444)))),
236+
new MapConfig(
237+
ImmutableMap.of("server", ImmutableMap.of("port", PortProber.findFreePort())))),
236238
handler);
237239
}
238240

java/server/test/org/openqa/selenium/grid/testing/TestSessionFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public Optional<ActiveSession> apply(CreateSessionRequest sessionRequest) {
6161
SessionId id = new SessionId(UUID.randomUUID());
6262
Session session = sessionGenerator.apply(id, sessionRequest.getCapabilities());
6363

64-
URL url = null;
64+
URL url;
6565
try {
6666
url = session.getUri().toURL();
6767
} catch (MalformedURLException e) {

0 commit comments

Comments
 (0)