Skip to content

Commit d6d672c

Browse files
[py] Remove thread.join in testing webserver
Due to https://bugs.chromium.org/p/chromedriver/issues/detail?id=3654#c1 Chrome doesn't release network resources properly.
1 parent 4a3bb6d commit d6d672c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

py/test/selenium/webdriver/common/webserver.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ def updir():
5555

5656
class HtmlOnlyHandler(BaseHTTPRequestHandler):
5757
"""Http handler."""
58+
5859
def do_GET(self):
5960
"""GET method handler."""
6061
try:
@@ -86,6 +87,7 @@ class ThreadedHTTPServer(ThreadingMixIn, HTTPServer):
8687

8788
class SimpleWebServer(object):
8889
"""A very basic web server."""
90+
8991
def __init__(self, host=DEFAULT_HOST, port=DEFAULT_PORT):
9092
self.stop_serving = False
9193
host = host
@@ -121,8 +123,6 @@ def stop(self):
121123
urllib_request.URLopener().open("http://%s:%d" % (self.host, self.port))
122124
except IOError:
123125
pass
124-
LOGGER.info("Shutting down the webserver")
125-
self.thread.join()
126126

127127
def where_is(self, path):
128128
return "http://%s:%d/%s" % (self.host, self.port, path)

0 commit comments

Comments
 (0)