Skip to content

Commit e717257

Browse files
committed
Fix closure tests by not stripping data attribute
1 parent 503248c commit e717257

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

common/private/selenium_test.bzl

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,16 @@ def selenium_test(name, test_class, size = "medium", browsers = None, **kwargs):
6363
tests = []
6464
test_name = test_class.rpartition(".")[2]
6565

66+
data = kwargs["data"] if "data" in kwargs else []
6667
jvm_flags = kwargs["jvm_flags"] if "jvm_flags" in kwargs else []
6768
tags = kwargs["tags"] if "tags" in kwargs else []
6869

6970
stripped_args = dict(**kwargs)
71+
stripped_args.pop("data", None)
7072
stripped_args.pop("jvm_flags", None)
7173
stripped_args.pop("tags", None)
7274

75+
7376
for browser in browsers:
7477
if not browser in _BROWSERS:
7578
fail("Unrecognized browser: " + browser)
@@ -82,14 +85,12 @@ def selenium_test(name, test_class, size = "medium", browsers = None, **kwargs):
8285
size = size,
8386
jvm_flags = _BROWSERS[browser]["jvm_flags"] + jvm_flags,
8487
tags = _BROWSERS[browser]["tags"] + tags,
88+
data = data,
8589
**stripped_args
8690
)
8791
tests.append(test)
8892

8993
if not "no-remote" in tags:
90-
data = kwargs["data"] if "data" in kwargs else []
91-
stripped_args.pop("data", None)
92-
9394
native.java_test(
9495
name = "%s-remote" % test,
9596
test_class = test_class,

0 commit comments

Comments
 (0)