clarify geom_smooth auto message#1951
Merged
hadley merged 2 commits intotidyverse:masterfrom Jan 26, 2017
Merged
Conversation
Member
|
Can you please add a bullet to NEWS.md too? |
Contributor
Author
|
Done. Let me know if you need anything else :-) |
Member
|
Thanks! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
stat_smooth's "auto" method reports the function that it chooses, but not the formula. Since the formula depends on the function it chooses, reporting it seems like a good idea.This is already in the docs, but putting it in the message will make it less likely for users to forget that they need to rewrite the formula (and tell their boss that the splines are just very close to being linear 😳).