Permit function devices to use file argument#3810
Merged
yutannihilation merged 4 commits intotidyverse:masterfrom Feb 24, 2020
Merged
Permit function devices to use file argument#3810yutannihilation merged 4 commits intotidyverse:masterfrom
file argument#3810yutannihilation merged 4 commits intotidyverse:masterfrom
Conversation
Member
yutannihilation
left a comment
There was a problem hiding this comment.
Thanks for catching this! This basically looks good to me. One corner case in my mind is when a function has both file and filename in its arguments, but I expect such functions are very few (or none).
Could you add a NEWS bullet?
Co-Authored-By: Hiroaki Yutani <yutani.ini@gmail.com>
Contributor
Author
|
Okay, fixed the styling and added a NEWS bullet as requested. |
Comment on lines
+9
to
+11
| * Support graphics devices that use the `file` argument instead of `fileneame` | ||
| in `ggsave()` (@bwiernik, 3810) | ||
|
|
Member
There was a problem hiding this comment.
Ah, sorry, we are now using NEWS.md instead of NEWS. Could you move this to NEWS.md?
yutannihilation
approved these changes
Feb 24, 2020
Member
|
Thanks! |
sthagen
added a commit
to sthagen/tidyverse-ggplot2
that referenced
this pull request
Feb 25, 2020
Permit function devices to use `file` argument (tidyverse#3810)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devices like
devEMF::emforCairo::CairoSVGusefileinstead offilename. They currently fail when provided indeviceto ggsave. This fixes that.Closes #3807