feat: add TOON decoding support #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
koinsaari
commented
Nov 7, 2025
- Adds decode() and decodeToJson() methods to JToon API
- Implements ValueDecoder with full TOON parser
- Adds DecodeOptions record with strict mode validation
- Extends StringEscaper with unescape methods
- Adds comprehensive tests with round-trip verification
- Updates README and CHANGELOG
Collaborator
|
@koinsaari, we are restricted to using Java 17 features. Please take a look at the use of some features, such as "getFirst()", that are not in Java 17. |
Closed
- Adds decode() and decodeToJson() methods to JToon API - Implements ValueDecoder with full TOON parser - Adds DecodeOptions record with strict mode validation - Extends StringEscaper with unescape methods - Adds comprehensive tests with round-trip verification - Updates README and CHANGELOG
felipestanzani
requested changes
Nov 9, 2025
Collaborator
felipestanzani
left a comment
There was a problem hiding this comment.
Please review this small change.
| */ | ||
| public final class JToon { | ||
|
|
||
| private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper(); |
Collaborator
There was a problem hiding this comment.
Please move this implementation to another class and keep this class as anemic as possible.
| * invalid | ||
| */ | ||
| public static String decodeToJson(String toon, DecodeOptions options) { | ||
| try { |
Collaborator
There was a problem hiding this comment.
Please move this implementation to another class and keep this class as anemic as possible.
Closed
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.