v1 of accname name computation tests - #39604
Merged
Merged
Conversation
cookiecrook
marked this pull request as ready for review
April 20, 2023 00:39
This was referenced Apr 20, 2023
Contributor
Author
|
The log of the unsuccessful |
Contributor
Author
|
Okay @spectranaut and @scottaohara this is really ready for review now that the PR checks have completed successfully. |
spectranaut
requested changes
Apr 24, 2023
spectranaut
left a comment
Contributor
There was a problem hiding this comment.
I would like to hear your thoughts on my one suggestion before approving!
spectranaut
approved these changes
Apr 25, 2023
spectranaut
left a comment
Contributor
There was a problem hiding this comment.
thx, this is a great start!
Contributor
Author
|
Hmmm… auto-merge bypassed the "do not merge yet" label. |
Contributor
Author
|
But it looks like it got everything, so I think that's okay? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes web-platform-tests/interop-accessibility#27
Closes w3c/accname#190