Commit 8b2bc26
committed
test: skip electron-main-no-esm on old node and cover node-commonjs require branch
The electron-main-no-esm bundle imports 'createRequire' from 'module', which
older Node versions cannot link in the vm ESM runner, so gate it behind
supportsRequireInModule. Require the electron built-ins in the node-commonjs
config so the require (commonjs) externals branch is executed.1 parent df09c29 commit 8b2bc26
3 files changed
Lines changed: 18 additions & 0 deletions
File tree
- test/configCases/target
- electron-main-module
- electron-main-no-esm
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| |||
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
0 commit comments