Initial approach to deleting stale cache - #13875
Closed
fforres wants to merge 5 commits into
Closed
Conversation
Contributor
|
For maintainers only:
|
fforres
force-pushed
the
fforres/delete_stale_cache
branch
from
July 27, 2021 06:55
95d746f to
cb16fb2
Compare
fforres
force-pushed
the
fforres/delete_stale_cache
branch
from
July 27, 2021 15:43
b7ccd42 to
1343f2b
Compare
Contributor
|
@fforres The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from azure (2 errors / 0 warnings) and appveyor (success) and fix these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the issues presented in #13291
This PR creates a new
purgeStaleCacheprop inside the cache options object and passing it down to decide if we should delete the stale caches or not.It also adds
cacheLocationto the file serialization contextWhat kind of change does this PR introduce?
It's a feature
Did you add tests for your changes?
Not yet
Does this PR introduce a breaking change?
Nope
What needs to be documented once your changes are merged?
A new prop on filesystem cache.