Update @@foo symbol notation to %Symbol.foo% notation - #1415
Merged
Conversation
This was referenced Jul 1, 2024
Member
|
It looks like this is based on an outdated copy; can you rebase on main? Also, I believe the way this is done, by just relying on |
domenic
approved these changes
Jul 2, 2024
domenic
left a comment
Member
There was a problem hiding this comment.
Well, it looks like the linking database did update, and thus my own PR started failing: 4035d0a was merged to main and failed to build on CI.
So I went ahead and fixed the merge conflict here, so that we can get main back to green, and will merge it shortly.
Contributor
Author
|
thanks! was just about to rebase it :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See tc39/ecma262#1314
Preview | Diff