Skip to content

fix(httpclient): ensure proper closure of HttpClient in shutdown method - #7390

Merged
jack-berg merged 2 commits into
open-telemetry:mainfrom
felixbarny:close-httpclient
Jun 9, 2025
Merged

fix(httpclient): ensure proper closure of HttpClient in shutdown method#7390
jack-berg merged 2 commits into
open-telemetry:mainfrom
felixbarny:close-httpclient

Conversation

@felixbarny

Copy link
Copy Markdown
Contributor

Fixes #7388

@felixbarny
felixbarny requested a review from a team as a code owner June 5, 2025 09:20
@codecov

codecov Bot commented Jun 5, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.79%. Comparing base (a756317) to head (7fc53da).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...ry/exporter/sender/jdk/internal/JdkHttpSender.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7390      +/-   ##
============================================
- Coverage     89.79%   89.79%   -0.01%     
  Complexity     6969     6969              
============================================
  Files           795      795              
  Lines         21122    21127       +5     
  Branches       2056     2057       +1     
============================================
+ Hits          18967    18971       +4     
  Misses         1495     1495              
- Partials        660      661       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks!

@jack-berg
jack-berg merged commit 6a164a9 into open-telemetry:main Jun 9, 2025
@felixbarny
felixbarny deleted the close-httpclient branch June 10, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JdkHttpSender leaks SelectorManager thread

2 participants