Skip to content

check also directories in check_case_conflict#575

Merged
asottile merged 1 commit into
pre-commit:masterfrom
slsyy:master
Apr 4, 2021
Merged

check also directories in check_case_conflict#575
asottile merged 1 commit into
pre-commit:masterfrom
slsyy:master

Conversation

@slsyy

@slsyy slsyy commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

fix #70

Comment thread pre_commit_hooks/check_case_conflict.py Outdated
Comment thread pre_commit_hooks/check_case_conflict.py Outdated
Comment thread pre_commit_hooks/check_case_conflict.py Outdated
Comment thread pre_commit_hooks/check_case_conflict.py Outdated
Comment thread tests/check_case_conflict_test.py
@slsyy slsyy force-pushed the master branch 2 times, most recently from e567150 to fd797fa Compare March 19, 2021 19:36
@slsyy

slsyy commented Mar 21, 2021

Copy link
Copy Markdown
Contributor Author

@asottile please re-review

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few small things -- sorry for the delay I've been very busy

Comment thread pre_commit_hooks/check_case_conflict.py Outdated
Comment thread pre_commit_hooks/check_case_conflict.py Outdated
Comment thread pre_commit_hooks/check_case_conflict.py Outdated

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

check-case-conflict doesn't notice directory name conflicts

2 participants