Changeset 245171 in webkit

Timestamp:

May 9, 2019, 11:44:13 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Limit number of prefetches of a given page
​https://bugs.webkit.org/show_bug.cgi?id=197736

Patch by Rob Buis <​rbuis@igalia.com> on 2019-05-09
Reviewed by Darin Adler.

Limit prefetches for same url to 1.

• NetworkProcess/cache/PrefetchCache.cpp:

(WebKit::PrefetchCache::store):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cache/PrefetchCache.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-05-09  Rob Buis  <rbuis@igalia.com>
+
+        Limit number of prefetches of a given page
+        https://bugs.webkit.org/show_bug.cgi?id=197736
+
+        Reviewed by Darin Adler.
+
+        Limit prefetches for same url to 1.
+
+        * NetworkProcess/cache/PrefetchCache.cpp:
+        (WebKit::PrefetchCache::store):
+
 2019-05-09  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp

@@ -70 +70 @@
     if (!m_sessionPrefetches)
         m_sessionPrefetches = std::make_unique<PrefetchEntriesMap>();
-    m_sessionPrefetches->set(requestUrl, std::make_unique<PrefetchCache::Entry>(WTFMove(response), WTFMove(buffer)));
+    auto addResult = m_sessionPrefetches->add(requestUrl, std::make_unique<PrefetchCache::Entry>(WTFMove(response), WTFMove(buffer)));
+    // Limit prefetches for same url to 1.
+    if (!addResult.isNewEntry)
+        return;
     m_sessionExpirationList.append(std::make_tuple(requestUrl, WallTime::now()));
     if (!m_expirationTimer.isActive())