Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null when no user name available #4892

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Fix null when no user name available #4892

merged 2 commits into from
Jun 9, 2023

Conversation

SKPG-Tech
Copy link
Contributor

@SKPG-Tech SKPG-Tech commented Jun 5, 2023

This fixes #4891

I'm not sure whether or not it is better to fix this or consider the other solution where it shows users without names on hover, but that's up for decision 😉. For now, it only fixes the null issue 😄.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@alexr00 alexr00 added this to the June 2023 milestone Jun 7, 2023
@alexr00 alexr00 merged commit d94b867 into microsoft:main Jun 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User hover shows null when writing the @username
3 participants