feat: default to ADC when gcloud cred helper is configured in docker/config.json when using docker go library
#9469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcloud cred helper is configured in docke…gcloud cred helper is configured in docker/config.json when using docker go library
…r/config.json when using docker go library
b59e9b3 to
1755dfc
Compare
ericzzzzzzz
approved these changes
Jul 12, 2024
idsulik
pushed a commit
to idsulik/skaffold
that referenced
this pull request
Jul 19, 2024
…r/config.json when using docker go library (GoogleContainerTools#9469)
renzodavid9
added a commit
to renzodavid9/skaffold
that referenced
this pull request
Jul 24, 2024
…r/config.json when using docker go library (GoogleContainerTools#9469)
renzodavid9
added a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #9457
Description
This will make Skaffold to first try to get credentials using ADC when a Docker credentials helper is configured to use
gcloudin the.docker/config.jsonfile. If it fails it will try to use the logic from the Docker go library (as it was before this change). If it fails, it will try to guess if the given registry is a Google Registry and will try to get creds from ADC.Follow-up Work
More PRs to remove
gclouddependency