Fix for material3 reference version - #117
Merged
Merged
Conversation
Igor Demin (igordmn)
approved these changes
Nov 23, 2021
Zahari Zahariev (harryzz)
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
…float.
## Proposed Changes
changes the `NavInflater` to allow integer default types with argType="float".
From now on this will work:
```xml
<argument
android:name="ratio"
android:defaultValue="0" <-- notice the value, 0 instead of 0.0
app:argType="float" />
```
before there was an error: `org.xmlpull.v1.XmlPullParserException: Type is float but found integer: 0`
## Testing
Test: ./gradlew navigation:navigation-runtime:connectedCheck
## Issues Fixed
Fixes: The bug on [https://issuetracker.google.com/issues/173766247](https://issuetracker.google.com/issues/173766247) being fixed
This is an imported pull request from androidx#117.
Resolves JetBrains#117
Github-Pr-Head-Sha: b60424e
GitOrigin-RevId: f54b9d3
Change-Id: Ic9e75bb4fe08973abd443008014a802dc6b19c1c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcoded Jetpack version for material3
Fix for JetBrains/compose-multiplatform#1442