Implement PlatformLocale and StringDelegate for k/wasm - #561
Merged
Conversation
Ivan Matkov (MatkovIvan)
requested changes
May 10, 2023
Ivan Matkov (MatkovIvan)
approved these changes
May 11, 2023
Igor Demin (igordmn)
pushed a commit
that referenced
this pull request
Jun 23, 2023
Test: ./gradlew test connectedCheck This is an imported pull request from androidx#561. Resolves #561 Github-Pr-Head-Sha: a898cbf GitOrigin-RevId: 299e56a Change-Id: Icfbd888c8fba3cab8972cfd3a014349b4d557435
Oleksandr Karpovich (eymar)
added a commit
that referenced
this pull request
Jul 7, 2023
* Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag`
Oleksandr Karpovich (eymar)
added a commit
that referenced
this pull request
Jul 10, 2023
* Implement PlatformLocale and StringDelegate for k/wasm (#561) * Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag` * Add a comment
Nikolai Rykunov (Walingar)
pushed a commit
to Walingar/androidx
that referenced
this pull request
Jul 11, 2023
JetBrains#625) * Implement PlatformLocale and StringDelegate for k/wasm (JetBrains#561) * Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag` * Add a comment
Vladimir Mazunin (mazunin-v-jb)
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Implement PlatformLocale and StringDelegate for k/wasm (#561) * Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag` * Add a comment
Oleksandr Karpovich (eymar)
added a commit
that referenced
this pull request
Sep 7, 2023
* Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag`
Oleksandr Karpovich (eymar)
added a commit
that referenced
this pull request
Oct 13, 2023
* Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag`
Oleksandr Karpovich (eymar)
added a commit
that referenced
this pull request
Nov 24, 2023
* Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag`
Oleksandr Karpovich (eymar)
added a commit
that referenced
this pull request
Dec 5, 2023
* Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag`
Oleksandr Karpovich (eymar)
added a commit
that referenced
this pull request
Dec 6, 2023
* Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag`
Zahari Zahariev (harryzz)
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
JetBrains#625) * Implement PlatformLocale and StringDelegate for k/wasm (JetBrains#561) * Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag` * Add a comment
Zahari Zahariev (harryzz)
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
Test: ./gradlew test connectedCheck This is an imported pull request from androidx#561. Resolves JetBrains#561 Github-Pr-Head-Sha: a898cbf GitOrigin-RevId: 299e56a Change-Id: Icfbd888c8fba3cab8972cfd3a014349b4d557435
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation relies on JS browser API
NOTE: the PR is to wasm-main branch!