Fix missing InterfaceOrientation rawValue, remove redundant logic - #583
Merged
Elijah Semyonov (elijah-semyonov) merged 4 commits intoMay 31, 2023
Merged
Conversation
Elijah Semyonov (elijah-semyonov)
requested a review
from Vladimir Mazunin (mazunin-v-jb)
May 30, 2023 15:21
| ) | ||
|
|
||
| /* | ||
| * On newest iOS interfaceOrientation will be deduced from [UIWindowScene] of [UIWindow] |
Collaborator
There was a problem hiding this comment.
newest
Please specify versions. This comment will be there in a few years with new iOS and possible new API
| /* | ||
| * On newest iOS interfaceOrientation will be deduced from [UIWindowScene] of [UIWindow] | ||
| * to which our [ComposeWindow] is attached. | ||
| * It's never UIInterfaceOrientationUnknown, if accessed after owning [UIWindow] was made key and visible: |
Collaborator
There was a problem hiding this comment.
It's never UIInterfaceOrientationUnknown
Why it's nullable then? Isn't it adding extra boxing?
There was a problem hiding this comment.
You can write a code, that will end up with accessing this property and getting null. And we don't need to do anything about it.
Oleksandr Karpovich (eymar)
approved these changes
May 31, 2023
Elijah Semyonov (elijah-semyonov)
deleted the
elijah.semyonov/orientation-bug-fix
branch
May 31, 2023 09:34
| // This fixes an interop use case when Compose is embedded in SwiftUi. | ||
| layer.layer.needRedraw() | ||
| } | ||
| super.viewWillTransitionToSize(size, withTransitionCoordinator) |
Collaborator
There was a problem hiding this comment.
Can we just remove this now? I mean after deleting everything aside super call in the last commit
There was a problem hiding this comment.
Actually yes. I'll need it in a branch where I want to make rotation animation not so clunky though. Could remove it altogether until then.
This was referenced May 31, 2023
Igor Demin (igordmn)
pushed a commit
that referenced
this pull request
Jul 10, 2023
Test: ./gradlew test connectedCheck Bug: 270612487 This is an imported pull request from androidx#583. Resolves #583 Github-Pr-Head-Sha: bdbe4b4 GitOrigin-RevId: c027806 Change-Id: Id251580331a2ddd3999abed175e954372c2be416
Zahari Zahariev (harryzz)
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
Zahari Zahariev (harryzz)
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
Test: ./gradlew test connectedCheck Bug: 270612487 This is an imported pull request from androidx#583. Resolves JetBrains#583 Github-Pr-Head-Sha: bdbe4b4 GitOrigin-RevId: c027806 Change-Id: Id251580331a2ddd3999abed175e954372c2be416
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove UIDeviceOrientation change notifications listening, since it's orthogonal to UIInterfaceOrientation
Differentiate between new and deprecated API for orientation retrieval based on iOS version.
Update orientation composition local inside
viewWillLayout.Orientation update will call
viewWillTransitionToSizefollowed byviewSafeAreaInsetsDidChangeandviewWillLayout. If orientation change happens when app is in background,viewSafeAreaInsetsDidChangeandwillViewLayoutwill still be called after it becomes active, so it's the best place for it.Testing
Test: run regenerate_xcodeproject.sh, launch the app.
Issues Fixed
Fixes: startup crash on xcodegen generated project. Crashes when creating ComposeWindow on iOS in case statusBarOrientation of UIApplication is invalid (usually before UIWindow becomes key and visible). Trying to proactively obtain current interface orientation before view is ready for layout is a bad idea.