[JS][bidi] added captureScreenshot command - #12510
Merged
pujagani merged 9 commits intoOct 17, 2023
Merged
Conversation
harsha509
reviewed
Aug 7, 2023
pujagani
reviewed
Sep 26, 2023
pujagani
reviewed
Sep 26, 2023
pujagani
reviewed
Sep 26, 2023
Contributor
|
Fixed/resolved all comments. The failing test is not associated with the changes. Can we merge this? |
diemol
approved these changes
Oct 17, 2023
aguspe
pushed a commit
to aguspe/selenium
that referenced
this pull request
Oct 22, 2023
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added captureScreenshot methods for different options (no clip, box, element) along with tests.
Motivation and Context
To implement BiDi command https://w3c.github.io/webdriver-bidi/#command-browsingContext-captureScreenshot
Add feature #12317
Types of changes
Checklist