Skip to content

[dotnet] Remove IdentityModel nuget from bazel workspace - #12834

Merged
titusfortner merged 3 commits into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-identitymodel-bazel
Sep 29, 2023
Merged

[dotnet] Remove IdentityModel nuget from bazel workspace#12834
titusfortner merged 3 commits into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-identitymodel-bazel

Conversation

@nvborisenko

@nvborisenko nvborisenko commented Sep 28, 2023

Copy link
Copy Markdown
Member

Description

We didn't clean IdentityModel dependency completely.

Motivation and Context

Fix .net CI build.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment thread dotnet/src/webdriver/Internal/Base64UrlEncoder.cs Outdated
@titusfortner
titusfortner merged commit 1992155 into SeleniumHQ:trunk Sep 29, 2023
@nvborisenko
nvborisenko deleted the dotnet-identitymodel-bazel branch September 29, 2023 12:57
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
…12834)

* Remove IdentityModel from bazel workspace

* Make Base64UrlEncoder as public

* Make Base64UrlEncoder back to internal
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 29, 2023
…12834)

* Remove IdentityModel from bazel workspace

* Make Base64UrlEncoder as public

* Make Base64UrlEncoder back to internal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants