Skip to content

[dotnet] Rename strong assembly name - #12861

Merged
shs96c merged 2 commits into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-assembly-strongnamed
Oct 4, 2023
Merged

[dotnet] Rename strong assembly name#12861
shs96c merged 2 commits into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-assembly-strongnamed

Conversation

@nvborisenko

@nvborisenko nvborisenko commented Oct 3, 2023

Copy link
Copy Markdown
Member

Description

Strong named packages should contain WebDriver.StrongNamed.dll inside. The same for Support package. Strong named Support package should be dependent on strong named WebDriver package.

Motivation and Context

Fixes #12316

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvborisenko
nvborisenko requested a review from shs96c October 3, 2023 13:49

@shs96c shs96c left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@shs96c
shs96c merged commit b42044e into SeleniumHQ:trunk Oct 4, 2023
@nvborisenko
nvborisenko deleted the dotnet-assembly-strongnamed branch October 4, 2023 09:12
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Selenium.Support.StrongNamed depends on Selenium.WebDeriver instead of strong name signed version

2 participants